Implement missing functionality for Door Locks

marcelveldt commented 1 year ago

From core created by AlCalzone: home-assistant/core#86955

The problem

grafik (the mentioned operation types mean constant 0x01 and timed 0x02, V4+ adds additional ones)

I could not find any way to configure the operation type of a lock, so this will need to be added before certification.

Also setting the lock mode (Locked, Unlocked, and several timed modes) must be available to the user if supported by the lock: grafik

What version of Home Assistant Core has the issue?

2023.1.7

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Z-Wave JS

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

marcelveldt commented 1 year ago

See the original issue in core for some discussion about this, the gist is that there are no configuration options missing but actual controls and sensors for door locks.

raman325 commented 1 year ago

@AlCalzone I started looking at this again. Can you review my assumptions and tell me which, if any are wrong?

We need to set all DoorLock CC parameters at the same time which we will do using the setConfiguration CC command.
outsideHandlesCanOpenDoor and insideHandlesCanOpenDoor are not required to be controllable by users.
outsideHandlesCanOpenDoor and insideHandlesCanOpenDoor must be sent as part of the setConfiguration CC command, so presumably we can just retrieve the current value of these parameters and resend them.
If the CC version is v4, only then will the following parameters be available: blockToBlock, holdAndReleaseTime, twistAssist, and blockToBlock
If the CC version is v4, all four parameters listed in 4 need to be sent as part of the setConfiguration CC command.
If the CC version < v3, we CANNOT include any of the parameters listed in 4 in the command.

AlCalzone commented 11 months ago

correct
correct
correct, but I think this should be done in the driver. The serialize function already has some fallbacks if those are not arrays, so they should be just made optional and default to 0xF as recommended if no value has been set before.
correct, but not all of them have to be supported by a lock. Z-Wave JS will only create the corresponding values if they are supported.
No, they are still optional. They will default to 0/false though if not provided. Might make sense to read the cached values in the setConfiguration command though.
You can pass them, but Z-Wave JS will not send them to the device.

raman325 commented 11 months ago

Might make sense to read the cached values in the setConfiguration command though.

Are you saying that if the v4 properties aren't included, the library should read the cached values or are you thinking about adding this to the driver?

AlCalzone commented 10 months ago

I'm not sure this is solved yet:

I have no idea what to fix here:

Not sure how to do this:

Setup Door Lock Mode to 'UnsecuredWithTimeout'

AlCalzone commented 10 months ago

Related to 2. in the above comment, other states than locked and unlocked can also not be displayed:

Please check if current mode is set to 'UnsecuredWithTimeout'. Is the mode displayed correctly?

AlCalzone commented 5 months ago

So, I got further this time, but setting the lock configuration still fails. This is because lockTimeoutConfiguration is missing from the configuration passed to the driver, even though the checkbox is set:

This field is required when the operation type is timed.

Also how is this supposed to be formatted? I can't get it to pass validation:

marcelveldt commented 3 months ago

Shouldnt this be in the expert UI ?

AlCalzone commented 1 month ago

Very, very short term fix:

[ ] In the service call zwave_js.set_lock_configuration, pass missing lockTimeoutConfiguration to the node-zwave-js API

Better:

[ ] Move the service call functionality to the expert UI. This needs one block where:
- User can select operation type among supported (Timed, Constant)
- User can check/uncheck inside/outside door handles (4, amount can not be detected)
- If operation type is timed, set the timeout min:sec
- If supported, set the auto relock time in seconds
- If supported, set the hold-and-release time in seconds
- If supported, enable/disable block-to-block functionality
- If supported, enable/disable twist assist
- One button to apply the changes
[ ] Afterwards, verify if this requirement is fulfilled for the door lock mode control on the device page:

Timed Operation modes MUST NOT be selectable by the end user if the door lock is not configured in Timed Operation

AlCalzone commented 1 month ago

Device diagnostics: zwave_js-01J2ZVFHVQG8V8J9D9360S4VCQ-Node 7-685335944bc32e1f4a03cdc5b3940b7d.json

MartinHjelmare commented 1 month ago

I think I've found the bug for missing lock timeout configuration. We don't include that attribute when building the dict from the dataclass that represents the lock configuration in the client library. So even though we pass the parameter from the integration it's not included in the parameters sent from the client to the server.

https://github.com/home-assistant-libs/zwave-js-server-python/blob/78c0ed02c5ffd0f57d991058eb099b82394d2a2f/zwave_js_server/const/command_class/lock.py#L177-L197

I'm working on a fix.

MartinHjelmare commented 3 weeks ago

Let's move the expert panel tasks to a new issue. I'll close this issue when merging the fix.

AlCalzone commented 3 weeks ago

Followup issue: https://github.com/zwave-js/certification-backlog/issues/48

zwave-js / certification-backlog