Treat Basic CC `currentValue` without `targetValue` as a numeric (?) sensor instead of a light

zwave-js / certification-backlog

Issues and discussions related to Z-Wave certification of HA + Z-Wave JS

1 stars 0 forks source link

Treat Basic CC `currentValue` without `targetValue` as a numeric (?) sensor instead of a light #28

Closed AlCalzone closed 4 months ago

AlCalzone commented 12 months ago

The recent changes to Basic CC exposed an issue where devices that "support" Basic CC, but cannot actually be controlled, appear as a light entity. The next version of node-zwave-js only exposes currentValue in this case.

This needs a change in the discovery scheme, so that currentValue without targetValue is considered a sensor and not a light/actor.

raman325 commented 11 months ago

got a device dump I can use?

raman325 commented 11 months ago

also is this going to require a reinterview?

AlCalzone commented 11 months ago

Do you have an Aeotec Multisensor 6 or something similar? That should exhibit the behavior. I think it might require a re-interview too because the Basic CC support information needs to be set correctly.

raman325 commented 11 months ago

Do you have an Aeotec Multisensor 6 or something similar? That should exhibit the behavior. I think it might require a re-interview too because the Basic CC support information needs to be set correctly.

I don't but it's fine, I will take the existing Aeotec Multisensor 6 dump and modify it for this purpose

marcelveldt commented 7 months ago

We had a little chat about this and came to a few conclusions;

[x] - The driver should hide Basic CC when it knows for certain there's a better alternative
[ ] - We should create a sensor from Basic CC without targetValue
[ ] - We should create switch + number entity for Basic CC with targetValue
[ ] - We should not abuse light platform for Basic CC
[x] - Nice to have would be that the device database can include info when to hide Basic CC

AlCalzone commented 7 months ago

Regarding the 1st point:

https://github.com/zwave-js/node-zwave-js/pull/6760 fixes an issue where mapped and hidden CCs could still contribute values that show up in UIs
https://github.com/zwave-js/node-zwave-js/pull/6773 adds the capability to map Basic CC to Binary Sensor CC for devices where this cannot be automatically determined. We'll have to incrementally identify devices that need this and update their config files.

...so I consider that done - the rest is on the HA side.