zwave-js / certification-backlog

Issues and discussions related to Z-Wave certification of HA + Z-Wave JS
1 stars 0 forks source link

Allow GET/SET config value of a custom configuration parameter #31

Open AlCalzone opened 6 months ago

AlCalzone commented 6 months ago

Allow the user to GET/SET a custom configuration value for a device. The device configuration panel needs to be expanded, as well as the websocket.

Image

AlCalzone commented 6 months ago

Related to this, I tried to use the set_config_parameter service to set an unknown config parameter as part of the certification tests and got this error, which kind of defeats the purpose of this service call UI (and causes the test to fail):

Image

marcelveldt commented 4 months ago

expert UI

MindFreeze commented 1 month ago

In order to remove the error from the service and make custom params possible we need this PR https://github.com/home-assistant-libs/zwave-js-server-python/pull/1080

AlCalzone commented 5 days ago

This is not working correctly. When getting a config parameter, the message sent to zwave-js-server has the parameter number in an options object, when it should be directly on the message: Image

vs.

Image

AlCalzone commented 5 days ago

Setting a value of 0 fails frontend validation: grafik

And when frontend validation passes, the message also has the incorrect options parameter: grafik

MindFreeze commented 5 days ago

This is not working correctly. When getting a config parameter, the message sent to zwave-js-server has the parameter number in an options object, when it should be directly on the message: Image

vs.

Image

This should be ok as it is transformed in the zwavejs-server https://github.com/zwave-js/zwave-js-server/blob/1fb161d20a6714489f8e05ad59e7cb66f18ba5cd/src/lib/common.ts#L95-L108

AlCalzone commented 5 days ago

The screenshot shows the actual contents of message (see the options property), which does not adhere to the IncomingCommandNodeGetRawConfigParameterValue interface. The message.parameter in the code you linked does not exist, it is available under message.options.parameter, which should not exist.