search

zwave-js / certification-backlog

Issues and discussions related to Z-Wave certification of HA + Z-Wave JS
1 stars 0 forks source link

Improve warning messages for insecure inclusion #41

Closed marcelveldt closed 1 month ago

marcelveldt commented 4 months ago

Issues/improvements

  1. Show right after the node was added, not at the end of the interview --> https://github.com/home-assistant/core/issues/117636

  2. Distinguish between the different reasons for insecure inclusion instead of "an error". See https://github.com/zwave-js/node-zwave-js/pull/5570 for details

  3. If a node has been security bootstrapped with the S0 Command Class in an S2 capable network, the SIS / Primary controller MUST issue a warning message to the user informing that the node has not been included securely. Requires 2. on the HA side

TODO Home Assistant (frontend):

  1. Show big fat warning that the node is being included insecurely at the start of the process.

  2. Show specific error message when inclusion failed, so show as much info as possible. The Driver has been adjusted to deliver this info.

  3. Show warning that the node was NOT added securely (despite the fact that the user choose secure inclusion).

MindFreeze commented 1 month ago

@marcelveldt I don't understand point 3. We already show a warning when the interview is finished. Is this about showing the specific error? Then it would just part of point 2, no?

marcelveldt commented 1 month ago

@marcelveldt I don't understand point 3. We already show a warning when the interview is finished. Is this about showing the specific error? Then it would just part of point 2, no?

@AlCalzone can explain this better than me but apparently it can be true that you choose secure inclusion but in the end the controller did not do that and the node got included without security.

MindFreeze commented 1 month ago

Sounds like displaying the reason after the node is added covers this, so if 1 & 2 are done, 3 is also covered

AlCalzone commented 1 month ago

I'll have to double check 3. - don't remember right now whether that required additional work.