Add controller status messages?

zwave-js / node-red-contrib-zwave-js

The most powerful, high performing and highly polished Z-Wave node for Node-RED based on Z-Wave JS. If you want a fully featured Z-Wave framework in your Node-RED instance, you have found it.

MIT License

47 stars 6 forks source link

Add controller status messages? #47

Closed crxporter closed 3 years ago

crxporter commented 3 years ago

I'm working on migrating from zwavejs2mqtt (I'm almost ready!) and thought it could be nice to have controller status passed to nodered as the node status.

Screenshot from the mqtt interface:

I was thinking it could probably be placed where the "All nodes ready!" Message appears?

I suppose the alternate option is enabling logs and just watching status there while I debug. Feel free to say "no" and close this one.

marcus-j-davies commented 3 years ago

Hey!

I was thinking it could probably be placed where the "All nodes ready!" Message appears?

Not a bad idea at all, I like it, these types of events are delivered via a node message, but can see why it would be much better to have them in view also.

Z-Wave JS Logging introduced a bug as of 7.2.4 (which is now fixed) https://github.com/zwave-js/node-zwave-js/issues/2490

Logging does not work, if the process does not have an interactive terminal (i.e running as a systemd service) Sometime this evening I will be dropping 3.3.0 which includes the Z-Wave JS version with logging being fixed (and other enhancements)

marcus-j-davies commented 3 years ago

@crxporter,

Just a courtesy ping, to advise 3.3.0 has dropped (should appear in Red ~1 Hour) This restores logging, if you need to use it for monitoring purposes.

I'll aim to include the controller status in the node for 3.3.x

3.3.0 Deprecation Warnings

Bump Z-Wave JS
Added new Association management methods via a new Associations class
The Managed Association and AssociationGroupInfo classes are now marked for removal.
Improvements/fixes to logger
Fixed Some UI weirdness
Improvements/fixes to Z-Wave Device Node

crxporter commented 3 years ago

Thank's for the heads up, I'm hoping to make the full switch over from mqtt this evening.

Edit - working on this now. I've started a discussions thread to discuss (see what I did there?) I'll leave this issue for what it actually is, the feature request.

marcus-j-davies commented 3 years ago

Do keep me updated. Feel free to get involved as you see fit 👍

marcus-j-davies commented 3 years ago

Something like this @crxporter

crxporter commented 3 years ago

Very cool!

Does it work for other controller messages? Like... inclusion, exclusion, or refresh?

Then probably back to green "ready" once it's through?

marcus-j-davies commented 3 years ago

yep.

it will project inclusion, exclusion , heal & interview

marcus-j-davies commented 3 years ago

@crxporter

Have just dropped 3.3.1 - Which brings the Controller status Text on the controller node (among other things)

Added an optional forceUpdate object for Managed mode usage. #51
Added the realtime status of the controller to the Node status text. #47
Z-Wave Node Name and Location are now stored on the target device (if supported, and updated)
Improved Controller status events to further describe the order
Updated the descriptions between Managed and Unmanaged Modes

I want to keep this open, until you have had a chance to spool it up. Hopefully the status text is pretty clear.
- Interview/re-interview Status
- Healing Status (for all nodes)
- Include/Exclude Status (when include has finished successfully, it should move to interview status)

crxporter commented 3 years ago

It's perfect. Awesome work.

I just interviewed a node then added a new device. Very nice to see each step progressing.

marcus-j-davies commented 3 years ago

Good to know!

The status text goes on bit if a rant, when no cache file is found (Z-Wave JS learning what's what) but after that, it's pretty settled.