search

zwave-js / node-red-contrib-zwave-js

The most powerful, high performing and highly polished Z-Wave node for Node-RED based on Z-Wave JS. If you want a fully featured Z-Wave framework in your Node-RED instance, you have found it.
MIT License
47 stars 6 forks source link

Add more Controller info to UI #67

Closed marcus-j-davies closed 3 years ago

marcus-j-davies commented 3 years ago

@crxporter

for 3.8.0 (next release)

marcus-j-davies commented 3 years ago

@crxporter.

I'm thinking of removing the device description (I think model number is enough). device description will be replaced with the firmware version.

Thoughts?

image

crxporter commented 3 years ago

We wouldn't loose much of anything if the current second line was hover-text for the first line. Is that difficult?

marcus-j-davies commented 3 years ago

Not difficult at all - just fiddly

crxporter commented 3 years ago

Your original implementation is good. All the information is in the values tables anyway, right?

marcus-j-davies commented 3 years ago

Yep, it's only the description of the devices being sacrificed - which I don't think is crucial.

crxporter commented 3 years ago

Full disclosure: I was still mostly asleep when I made the first comment about hover text.

Highlighting firmware is cool, but gives me another question... do you have any plans to add firmware updates?

Do we have cli-level access to Zwave-js while it runs in nodered? Maybe that would be a better option for firmware instead of adding it inside NR.

Of course we could just stop nodered, update with cli, then head back to nodered...

Sorry now I'm getting sidetracked. This can be another issue for another time.

marcus-j-davies commented 3 years ago

So,

Adding firmware update support, has been in the back of my mind. However, it is a delicate process, and I want to implement it correctly, and most importantly, implement it to be stable.

Z-Wave JS, has the methods, but it wants the binary file/firmware file etc etc. This is where my "focus" is - trying to make it as simple (and trouble free as possible).

its on my todo - Watch this space 👍