search

zwave-js / node-zwave-js

Z-Wave driver written entirely in JavaScript/TypeScript
https://zwave-js.github.io/node-zwave-js/
MIT License
750 stars 600 forks source link

Inovelli LZW30-SN missing Parameter 13 #2002

Closed jayscovill closed 3 years ago

jayscovill commented 3 years ago

Which device is missing?

Inovelli LZW30-SN configuration parameter 13

What are the IDs?

Manufacturer ID: 0x031e Product type: Where do I find this? Product ID: 0x0002:0x0001

As of FW 1.17 Inovelli added a parameter 13 to specify load type but it is not in the configuration database for the device.

https://support.inovelli.com/portal/en/kb/articles/firmware-v1-17-beta-lzw30-sn-switch-red-series-gen-2

ehsman commented 3 years ago

I'm guessing that the LZW30-SN might need multiple configs like LZW31-SN. As there is also a parameter 51 (same in the existing LZW31-SN config) added in firmware 1.19

https://support.inovelli.com/portal/en/kb/articles/firmware-v1-19-beta-lzw30-sn-switch-red-series-gen-2

AlCalzone commented 3 years ago

FYI: We now have the capability to define config parameters conditionally for specific firmware ranges in one file. https://zwave-js.github.io/node-zwave-js/#/development/config-files?id=conditional-configuration-settings

maverick1872 commented 3 years ago

@AlCalzone I assume a PR to update https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/devices/0x031e/lzw30-sn.json with a conditional configuration on parameters 13 & 51 would be all that's needed?

AlCalzone commented 3 years ago

I think so, yes.

AlCalzone commented 3 years ago

fixed in https://github.com/zwave-js/node-zwave-js/pull/2025