zwave-js / node-zwave-js

Z-Wave driver written entirely in JavaScript/TypeScript
https://zwave-js.github.io/node-zwave-js/
MIT License
749 stars 599 forks source link

Improvements for route/lifeline health checks #4075

Closed marcus-j-davies closed 1 year ago

marcus-j-davies commented 2 years ago

As Per slack discussion

They can abort already - but it only detaches the event listeners and closes the window - I couldn't see in the docs a way to abort it officially - So it is left to run in the background without the user getting feedback or the results.

Might be a good idea to add support for aborting actually...

and maybe checkRouteHealth also.

robertsLando commented 2 years ago

Would also make sense to return last finished result in healtcheck progress callback instead of just the last rating

AlCalzone commented 2 years ago

Additionally:

robertsLando commented 2 years ago

ah the failed pings is only included at the highest powerlevel. anything below implies 0/10

mundschenk-at commented 2 years ago

I've just triggered #4130 in my network after testing the Health Check functionality. I was wondering why some sensors missed reports today, so I looked at today's logfile: It's about 500 MB for 17 hours 😬

Incidentally, this looks like a good way to stress-test the resolution of #3906.

AlCalzone commented 1 year ago

All points should be solved now.