Inovelli Red on/off switch - lzw30-sn security column has gray question mark circle in zwjs2mqtt

apaperclip commented 2 years ago

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?

NO, my problem is NOT within Home Assistant or the ZWave JS integration

Is your problem within ZWaveJS2MQTT?

YES, BUT a ZWaveJS2MQTT developer has told me to come here

Checklist

[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem was not mentioned there.

Describe the bug

What causes the bug? Added an lzw30-sn with no encryption

What do you observe? Security is unknown (no encryption was selected during inclusion) Other no security devices have red hyphen circle (they are not inovelli)

Node debug info json has isSecure as unknown as well

What did you expect to happen? Security status should be red hyphen circle (no security mouse over)

Steps to reproduce the behavior:

Include device with no security
Put device in incusion mode (single up-click)
Observe control panel device overview table.
Note gray question mark for Security

Device information

Manufacturer: Inovelli Model name: lzw30-sn Node ID in your network: 10

How are you using `node-zwave-js`?

[X] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[ ] HomeAssistant zwave_js integration (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?

version: 9.2.2 (in zwjs2mqtt 6.9.1) node-zwave-js branch: zwavejs2mqtt branch:

Did you change anything?

no

If yes, what did you change?

No response

Did this work before?

No, it never worked anywhere

If yes, where did it work?

No response

Attach Driver Logfile

Logs include a re-interview with Reset Security Classes checked zwavejs_2022-05-18.log .

AlCalzone commented 2 years ago

This is why:

[Node 010] supports Security S2, but no S2 network keys were configured.

The driver cannot determine if the node has any S2 keys granted.

apaperclip commented 2 years ago

I can add them, but since I don't need anything with S2 I was not going to define them.

my thought process is:

Is the security value supposed to indicate how the node is associated or what is possible?
I would expect if the device is using not encryption, then defining s2 keys would not matter. The driver knows its not using encryption so the security value should be none. Why would the driver care if s2 keys are not provided if they're not needed for a node?

AlCalzone commented 2 years ago

The driver knows its not using encryption

It doesn't. The current logic is, as long as at least one security class is not a definite yes or no, the security status is unknown.

Maybe this should have a few more heuristics though...

AlCalzone commented 2 years ago

Ok so this issue is twofold:

S0 and non-secure inclusion didn't correctly remember which keys were not granted, resulting in this (?) status. This will be fixed in https://github.com/zwave-js/node-zwave-js/pull/4637
When S2 keys are not configured, after re-interview with "reset security classes" it is impossible to programmatically determine the security status of an insecure device for sure. It could be that the device was previously included with S2, yet without keys this cannot be tested. This part is working as intended.

apaperclip commented 2 years ago

Thank you for looking at this again!

zwave-js / node-zwave-js