zwave-js / node-zwave-js

Z-Wave driver written entirely in JavaScript/TypeScript
https://zwave-js.github.io/node-zwave-js/
MIT License
742 stars 593 forks source link

Issues with TKB Wall switches driver #4841

Closed GAguado closed 1 year ago

GAguado commented 2 years ago

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?

YES, BUT a Home Assistant developer has told me to come here

Is your problem within ZWaveJS2MQTT?

NO, my problem is NOT within ZWaveJS2MQTT

Checklist

Describe the bug

I have found that the wall switch TKB TZ56D is included incorrectly as a TZ36D and with only the left pad functional (load switch). The right pad, and double right pad sensors are not included/discovered and therefore can not be used.

The same happens with the model TZ66D, any right pad or double right-click functionality is included. In this case, the model TZ66D is properly discovered. This limits seriously the use of these popular wall switches.

Only entities discovered in both cases (after several trials):

image

I'm using the latest version 0.1.64

These devices are properly configured with other Z-Wave controllers

Device information

Manufacturer: TKB Model name: TZ56D / TZ66D Firmware 2.5 0x010c00040008032503ffcc0000e9 [Node 008]

How are you using node-zwave-js?

Which branches or versions?

Home Assistant 2022.7.6 Supervisor 2022.07.0 Operating System 8.2 Frontend 20220707.1 - latest

Did you change anything?

no

If yes, what did you change?

No response

Did this work before?

Don't know, this is a new device

If yes, where did it work?

No response

Attach Driver Logfile

First two messages with left pad use, last two when trying to use the right pad (any message) or double-right:

Subscribed to Z-Wave JS Log Messages…
2022-07-25T08:01:25.028Z SERIAL « 0x010c00040008032503ffc70000e2                                      (14 bytes)
2022-07-25T08:01:25.033Z CNTRLR   [Node 008] [~] [Binary Switch] currentValue: false => true        [Endpoint 0]
2022-07-25T08:01:25.039Z SERIAL » [ACK]                                                                   (0x06)
2022-07-25T08:01:25.056Z DRIVER « [Node 008] [REQ] [ApplicationCommand]
                                  └─[BinarySwitchCCReport]
                                      current value: true
2022-07-25T08:01:27.545Z SERIAL « 0x010c0004000803250300c400001e                                      (14 bytes)
2022-07-25T08:01:27.547Z CNTRLR   [Node 008] [~] [Binary Switch] currentValue: true => false        [Endpoint 0]
2022-07-25T08:01:27.550Z SERIAL » [ACK]                                                                   (0x06)
2022-07-25T08:01:27.553Z DRIVER « [Node 008] [REQ] [ApplicationCommand]
                                  └─[BinarySwitchCCReport]
                                      current value: false
2022-07-25T08:01:49.243Z SERIAL « 0x011700498408110410015e86725a738559252027702b2c7a59                (25 bytes)
2022-07-25T08:01:49.248Z SERIAL » [ACK]                                                                   (0x06)
2022-07-25T08:01:49.252Z DRIVER « [Node 008] [REQ] [ApplicationUpdateRequest]
                                    payload: 0x08110410015e86725a738559252027702b2c7a
2022-07-25T08:01:49.257Z CNTRLR « [Node 008] Received updated node info
2022-07-25T08:02:07.684Z SERIAL « 0x011700498408110410015e86725a738559252027702b2c7a59                (25 bytes)
2022-07-25T08:02:07.686Z SERIAL » [ACK]                                                                   (0x06)
2022-07-25T08:02:07.689Z DRIVER « [Node 008] [REQ] [ApplicationUpdateRequest]
                                    payload: 0x08110410015e86725a738559252027702b2c7a
2022-07-25T08:02:07.692Z CNTRLR « [Node 008] Received updated node info
kpine commented 1 year ago

Based on the dump, the driver is not exposing any value IDs for Basic CC, so HA cannot create any entities. HA only creates entities for values it is told about.

@AlCalzone Many devices that report button presses with BasicCC::Set use events instead of values. Is configuring this device to use events not an option?

GAguado commented 1 year ago

Who is the question addressed to? I have not much infomation about device internals except the user manual in which they (TKB) describes the use of groups:

https://doc.eedomus.com/files/TKB%20New%20wall%20switch%20manual%20(TZ56S,%20TZ56D,%20TZ55S,%20TZ55D%20&%20more).pdf

GAguado commented 1 year ago

If is me saying that I didn't see any event in HA for this popular TKB wall switch related with either right pad click or double right click

GAguado commented 1 year ago

Dear Team, any news on this? I have a similar issue with the Fibaro Button FGPB-101, J-Wave JS only triggers one click when this button has double and triple clicks Best Regards Gerardo

69leo commented 1 year ago

Hello, I am also interested in solving this problem. I have several TZ66D switches. Previously used Z-wave.me and single and double right-click supported the management of associations with other devices. On HA, the right key does not work completely. What is needed to fix this? And the second problem. Of the 4 TZ66Ds, when turned on and off with a physical switch key, two of them do not change their state in HA. I excluded them and reconnected them. Two send states, two don't. Firmware versions of TZ66D are the same

69leo commented 1 year ago

Судя по дампу, драйвер не предоставляет никаких идентификаторов значений для Basic CC, поэтому HA не может создавать какие-либо сущности. HA создает сущности только для значений, о которых ему говорят.

@AlCalzoneМногие устройства, которые сообщают о нажатиях кнопок с помощью BasicCC::Set, используют события вместо значений. Настройка этого устройства для использования событий не вариант?

Hello, can you explain in detail how to set this up?

AlCalzone commented 1 year ago

Sorry for the delay. The linked PR should make it so that the right paddle shows up as Basic Set events in HA. Like I said previously, I don't see a way to distinguish single and double tap though.