search

zwave-js / node-zwave-js

Z-Wave driver written entirely in JavaScript/TypeScript
https://zwave-js.github.io/node-zwave-js/
MIT License
741 stars 594 forks source link

Ultraloq Pro Z-wave #5445

Closed JPDMaker closed 1 year ago

JPDMaker commented 1 year ago

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?

NO, my problem is NOT within Home Assistant or the ZWave JS integration

Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?

NO, my problem is NOT within Z-Wave JS UI

Checklist

Describe the bug

[77-98-0-latchStatus] Current status of the latch is always reporting "OPEN"

U-tec support said the issue could be on the z wave hub side. Thread of others reporting the same issue: https://community.u-tec.com/t/expand-and-fix-z-wave-capabilities/502/18

Device information

Manufacturer: u-tec Model name: U Bolt Pro Z wave Node ID in your network: <077>

How are you using node-zwave-js?

Which branches or versions?

zwave-js-ui: 8.6.3.c12b1c6 zwave-js: 10.3.1

Did you change anything?

no

If yes, what did you change?

No response

Did this work before?

Don't know, this is a new device

If yes, where did it work?

No response

Attach Driver Logfile

zwavejs_current.log

efaden commented 1 year ago

Having same issue, also the door status is always open. Doesn't seem to report the state of the sensors correctly. According to their zwave documentation both should be on the reports. Different parts of the door condition

efaden commented 1 year ago

Screenshot_20230211-102053

AlCalzone commented 1 year ago

I'll try on Monday

efaden commented 1 year ago

Thanks. There really should be two entities for the pro if the sensor is present. One for the lock, and one for the door sensor

AlCalzone commented 1 year ago

That's a bug in the device firmware, at least in v1.1.3 which my lock is on. When being queried for the supported door components, it has the byte set to 6: grafik

which means Bolt and Latch states are supported, Door state isn't: grafik

Given that the manual states that Bolt and Door are supported, this seems like a bug.

AlCalzone commented 1 year ago

Despite that, I can't get the lock to report any change in door state. It always reports door open.

efaden commented 1 year ago

Well that's not awesome. I send an email to them about this issue with this thread... Maybe they can fix it. Would be great to be able to get door status

tekkenly commented 1 year ago

Hi @AlCalzone ,

I wonder if we can put some special code in to make a fix for this device and this version firmware? the outdoorhandle value is clearly matching the door sensor state.

Or, if you can give me a quick hint where the related code is, I can try to make a change, then you can choose if you want to merge it in.

Thanks.

AlCalzone commented 1 year ago

We don't hardcode such one-time device-specific behavior.

AlCalzone commented 1 year ago

I've heard that U-Tec finally managed to reproduce the issue, but no idea if and when this will be fixed.

johntdyer commented 1 year ago

@AlCalzone do you have a link to their issue I can follow ?

AlCalzone commented 1 year ago

Nope, that was all back-channel information. Haven't head anything since.

TheOneOgre commented 1 year ago

I would like to add that they have seemingly made no progress on fixing this issue and I have discovered a second issue and it seems others have as well.

When the lock is triggered to lock, even if the locking process fails, say the door isn't closed all the way or something happens to make it not engage the deadbolt, the lock will beep and error out but the reported status to z-wave is that the lock was successful. This is dangerous as even though you should always manually check for security, it should report some kind of error or at least fallback to the previous state. Kind of disappointed in Ultraloq on the development of this.

efaden commented 1 year ago

Yeah, the lock is good, but if they don't actually fix bugs then it's really not a great choice

On Tue, Jul 4, 2023, 10:31 TheOgre @.***> wrote:

I would like to add that they have seemingly made no progress on fixing this issue and I have discovered a second issue and it seems others have as well.

When the lock is triggered to lock, even if the locking process fails, say the door isn't closed all the way or something happens to make it not engage the deadbolt, the lock will beep and error out but the reported status to z-wave is that the lock was successful. This is dangerous as even though you should always manually check for security, it should report some kind of error or at least fallback to the previous state. Kind of disappointed in Ultraloq on the development of this.

— Reply to this email directly, view it on GitHub https://github.com/zwave-js/node-zwave-js/issues/5445#issuecomment-1620360640, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAEABHC2QPSLJ2OFVBKUTLXOQSNJANCNFSM6AAAAAAUXA6EVU . You are receiving this because you commented.Message ID: @.***>

TheOneOgre commented 1 year ago

Yeah, the lock is good, but if they don't actually fix bugs then it's really not a great choice

I completely agree. The firmware version of my lock is 02.26.0022 which, from how it reads, is from February of 2022, so no firmware updates in almost a year and a half. For something that's supposed to be a "Work With Home Assistant" product, that's a pretty unacceptable lack of updates especially when there are glaring bugs.

balloob commented 1 year ago

We have decided to terminate the Works with Home Assistant relationship with Ultraloq. We had reported these issues with them and were discussing solutions. However, they ceased communication from their end and we have received no further updates.

TheOneOgre commented 1 year ago

We have decided to terminate the Works with Home Assistant relationship with Ultraloq. We had reported these issues with them and were discussing solutions. However, they ceased communication from their end and have received no further updates.

Good to see some action being taken about this. Thanks for keeping Home Assistant great!

AlCalzone commented 1 year ago

I'm afraid there's nothing to be done in this project, since the functionality is just broken.

holblin commented 1 year ago

Could we update https://www.home-assistant.io/integrations/ultraloq/ ?

b-uwe commented 1 year ago

@TheOneOgre @holblin @AlCalzone https://github.com/home-assistant/home-assistant.io/pull/28166

jack0li commented 1 year ago

This problem has been solved in the new firmware, which can be upgraded online through Home assistant.

God-TM commented 1 year ago

Will it be added back into the WWHA partner program?

jack0li commented 1 year ago

Yes, we do our best to add it back.

Thanks!

@.***

From: God-TM Date: 2023-08-23 08:51 To: zwave-js/node-zwave-js CC: jack; Comment Subject: Re: [zwave-js/node-zwave-js] Ultraloq Pro Z-wave (Issue #5445) Will it be added back into the WWHA partner program? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

TheOneOgre commented 1 year ago

Will it be added back into the WWHA partner program?

I wouldn't think it would or should be added back. Ignoring HA devs, not providing timely updates, not notifying users of issues, and overall not being easy to work with, is an easy disqualifier for being in a partner program. I think the biggest thing was the untimely manner in which they handled this and the complete lack of communication.

Also, I haven't tested it yet but, can anyone confirm if the "false lock" bug is still occurring where if the lock is told to lock, but fails due to the door being slightly open or something, the state is still reported as "Locked"? Was a HUGE oversight before if you relied on that status for your door being locked.

brettmiller commented 1 year ago

Also, I haven't tested it yet but, can anyone confirm if the "false lock" bug is still occurring where if the lock is told to lock, but fails due to the door being slightly open or something, the state is still reported as "Locked"? Was a HUGE oversight before if you relied on that status for your door being locked.

Tested and the "false lock" bug still exists.

b-uwe commented 1 year ago

Will it be added back into the WWHA partner program?

I wouldn't think it would or should be added back. Ignoring HA devs, not providing timely updates, not notifying users of issues, and overall not being easy to work with, is an easy disqualifier for being in a partner program.

Things have changed drastically in the last few weeks! Please feel free to put that to a test! I' doing exactly so with the last statement, the "false lock" bug which I expect to be worked on very soon. But that's why, yes, we plan to add them back to the WWHA partner program!

jack0li commented 1 year ago

Also, I haven't tested it yet but, can anyone confirm if the "false lock" bug is still occurring where if the lock is told to lock, but fails due to the door being slightly open or something, the state is still reported as "Locked"? Was a HUGE oversight before if you relied on that status for your door being locked.

Tested and the "false lock" bug still exists.

Thanks for Testing. I will check it ASAP.

God-TM commented 1 year ago

I just tested it. Perhaps I'm not understanding what's wrong here, but when I open and close the door, the sensor labled "Current status of the door" goes from Open to Closed and vice-versa accurately reflecting the state of the door. I can tell it to lock in either state, and the state is still either Open or Closed depending on if it's actually open or closed...

jack0li commented 1 year ago

I have tested it, the door status is correct depending the open or close operation.
Please put the door magnet as close as possible to the lock, the farther the magnet is, the weaker the magnetic is. Can you show me your test environment picture include the lock and door magnet ？

God-TM commented 1 year ago

I used to have a Gen 2 August Pro there, so I left the magnet from that and used it with the Ultraloq Pro. So far it's been working without any issues. IMG_8812 IMG_8813 IMG_8814 IMG_8815 IMG_8816

Please let me know if I can take any better measurements or angles that might be helpful for you.

I did test the scenario where you close it mostly but leave it a bit misaligned. If I tell it to lock, it technically goes into a lock status (and I see I can unlock the door). But the sensor is still showing the door is open as well. I don't believe this is any different than what the August Pro would do.

jack0li commented 1 year ago

Thanks for your info.

  1. Can you gvie your lock Serial Number （SN：xxxxx）,inside of the battery cover ?
  2. The magnet detection chip in the lock and the detection algorithm are different from August, we don't do compatibility test with August magnet. Can you install ultraloq magnet as installation guide and test again？
God-TM commented 1 year ago

I'm not the one having issues with this lock (I figured I'd take pictures of a working environment if it could help anyone)... I'd rather not break what's currently working for me.

JPDMaker commented 1 year ago

I tested the lock jam bug. Does not update status.

lock serial number: 8030305122130050

IMG_8226 IMG_8228

This occurs both when the door is sensed to be closed or open

IMG_8231 IMG_8230 Paper used to force jam while closed.

jack0li commented 1 year ago

Do our best to optimizing them.

jack0li commented 1 year ago

hi JPDMaker， Where should the status of Jam be displayed in home assistance UI?

JPDMaker commented 1 year ago

It’s the state of the lock entity. Should update state to either ; Jammed, Locked, Locking, Unlocked, Unlocking, Unavailable, Unknown

https://developers.home-assistant.io/docs/core/entity/lock/

kpine commented 1 year ago

It’s the state of the lock entity. Should update state to either ; Jammed, Locked, Locking, Unlocked, Unlocking, Unavailable, Unknown

The Z-Wave integration does not support any of the extra lock states like jammed. It only supports locked or unlocked.

You can make HA feature requests at https://community.home-assistant.io/c/feature-requests/13.

HarlemSquirrel commented 1 year ago

Oh we definitely should have those states!

HarlemSquirrel commented 1 year ago

Took me a while to track this down but this appears to be set in https://github.com/home-assistant-libs/zwave-js-server-python/blob/0.51.1/zwave_js_server/const/command_class/lock.py#L81-L86

Then mapped in HA core in https://github.com/home-assistant/core/blob/2023.8.4/homeassistant/components/zwave_js/lock.py#L40-L49

AlCalzone commented 1 year ago

Jammed is not a lock state in node-zwave-js. It's a notification variable, which gets translated to a sensor in HA, I think here: https://github.com/home-assistant/core/blob/7548c4aced3872c0d685ae0b07529a1f20fddbcd/homeassistant/components/zwave_js/discovery.py#L773-L785

kpine commented 1 year ago

Yes, there is a lock jammed sensor (https://github.com/home-assistant/core/blob/7548c4aced3872c0d685ae0b07529a1f20fddbcd/homeassistant/components/zwave_js/binary_sensor.py#L139-L145).

So the lock entity could use this value. PRs are welcome.

(Deleted my other incorrect reply).

jack0li commented 1 year ago

This issue( When the lock is jammed,the lock status is lock, user can not lock again) is fixed. We are trying to add the jammed notifacation funcation, need more time.

itsensellc commented 11 months ago

New Z-Wave U-Bolt Pro, latest firmware applied, latest HAOS/core, status is still stuck at open for u_bolt_pro_z_wave_smart_lock_current_status_of_the_door. The app shows correctly so the position sensor is working.

AlCalzone commented 11 months ago

I still find it tricky to trigger changes of the sensor without mounting the lock in a doorframe, but I haven't managed to get the state in the app and HA out of sync. When the status does change, I see it in both. Might be a connectivity issue?

itsensellc commented 11 months ago

I still find it tricky to trigger changes of the sensor without mounting the lock in a doorframe, but I haven't managed to get the state in the app and HA out of sync. When the status does change, I see it in both. Might be a connectivity issue?

Don't think so? After latest update the door status seems to be working slightly better. What consistently seems to not work is auto-lock after X seconds doesn't seem to update the lock status. Opening the door from outside and then it locking automatically when closed is working. But if I open it from HA, then it auto locks after 15 seconds... the status does not get updated.

AlCalzone commented 11 months ago

auto-lock after X seconds doesn't seem to update the lock status

Wait, are we talking about the lock status or the door status?

itsensellc commented 11 months ago

auto-lock after X seconds doesn't seem to update the lock status

Wait, are we talking about the lock status or the door status?

Sorry I kind of switched gears. Door open status seems to be a bit better since the latest update. However the auto-lock has been an issue since adding the lock. Anytime I manually unlock it, that gets tracked properly in HA. Anytime it automatically locks it seems to not get tracked. I hit the lock in HA, and the status changes but the lock does nothing which is what I'd expect. So it knows it's already locked at least!

AlCalzone commented 11 months ago

Ok I'll try to reproduce that tomorrow

jack0li commented 11 months ago

I have tested in our site. The lock updates the correct status after auto-lock. For testing door status,please move the lock body,don't move magnet.

The version of my lock. The firmware version(in u-tec app show):02.26.0022 The Z-wave firmware version(HA show):1.5.3

Can you share me the testing video? We want more operate details to debug the issue. Thanks.

auto-lock

itsensellc commented 11 months ago

I have tested in our site. The lock updates the correct status after auto-lock. For testing door status,please move the lock body,don't move magnet.

The version of my lock. The firmware version(in u-tec app show):02.26.0022 The Z-wave firmware version(HA show):1.5.3

Can you share me the testing video? We want more operate details to debug the issue. Thanks.

auto-lock

Ok I have some further testing results. Door open status seems to be working perfectly fine for the moment. Door lock status status when opened at the lock seems perfectly fine, including when it auto locks. When I open the lock via the app, and it auto locks, status is reported fine. It's only when I open the door via HA that this issue occurs. And it doesn't seem to matter which kind of card I use. I can open the lock, it will update the status, but when the lock auto locks the HA state still reflects unlocked. When I click it again, it will beep and indicate lock. Sometimes this can get totally out of sync where it think it's unlocked but it's actually locked or vice versa. So it's only when controlling via HA that this is occurring. I can try and make a video if it's helpful I just wanted to clarify that first.