Extraction script from OpenSmartHouse needs adjustments

apella12 commented 9 months ago

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?

NO, my problem is NOT within Home Assistant or the ZWave JS integration

Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?

NO, my problem is NOT within Z-Wave JS UI

Checklist

[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem was not mentioned there.

Describe the bug

What causes the bug? Running this script; yarn run config import -s oh -Dd --ids xxxx

What do you observe? Script wrongly sets allowManualEntry=true when the OpenSmartHouse "limit to options" is true. In the OpenSmartHouse context the limit to options =true means that only the options shown are allowed. In the zwave-js context this means allowManualEntry=false. Also the PR checker informed me allowManualEntry=true is not allowed (I'm assuming it is deemed unnecessary), so script should ideally not add the allowManualEntry parameter if the OpenSmartHouse limit to options is false.

Device information

Manufacturer: Model name: Node ID in your network:

How are you using `node-zwave-js`?

[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker image (latest)
[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker image (dev)
[ ] zwave-js-ui (formerly zwavejs2mqtt) Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[ ] HomeAssistant zwave_js integration (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[X] Manually built from GitHub (please specify branch)
[ ] Other (please describe)

Which branches or versions?

version: node-zwave-js branch: 12.0.0-beta.3

Did you change anything?

no

If yes, what did you change?

No response

Did this work before?

Don't know, this is a new device

If yes, where did it work?

No response

Attach Driver Logfile

This is script issue. The only report is DONE; DONE

zwave-js-bot commented 9 months ago

👋 Hey @apella12!

Thanks for opening an issue! It doesn't look like you provided a logfile though. While not strictly necessary for every issue, having a driver log is required to diagnose most issues.

Please consider uploading a logfile that captures your problem.

AlCalzone commented 9 months ago

Happy to take a PR if you feel comfortable with that. If not I can do it next week.

apella12 commented 9 months ago

I'll haven't located the file yet, but can try and take a look for a PR. Just wanted to note the issue first.

EDIT: This looks a little beyond me. I think this is the line, but don't know how to modify. Sorry.. allowManualEntry: param.limit_options === "1",

zwave-js / node-zwave-js