zwave-js / node-zwave-js

Z-Wave driver written entirely in JavaScript/TypeScript
https://zwave-js.github.io/node-zwave-js/
MIT License
750 stars 602 forks source link

Yale Lock Inclusion Issue: Inconsistent ACK Responses During Interview Process #7129

Closed Siburanjan closed 1 month ago

Siburanjan commented 2 months ago

Checklist

Deploy method

Manually built (git clone - npm run build - npm install

Z-Wave JS UI version

1.0.0

ZwaveJS version

11.14

Describe the bug

I've been testing the inclusion process of Yale locks using Zniffer and encountered an issue that might be worth investigating further. During the interview process, the lock occasionally sends a manufacturer_specific_report frame. On some occasions, the Gateway (GW) fails to acknowledge (ACK) this specific report sent by the lock. As a result of the missing ACK, the lock emits an error sound, indicating a failure at the lock level. Despite the error sound, the interview process continues and is completed successfully at the protocol level. I am attaching the Zniffer log files link for your reference.

https://drive.google.com/drive/folders/1tZD1bMb0FQXkUAivFdlSBH8HjhqGKyMJ?usp=drive_link

To Reproduce

The behaviour is repeating itself automatically. Out of 10 times the behaviour is repeated 8 times itself.

Expected behavior

Inclusion Success Announcement from the device instead of Failure announcement even after successful addition.

Additional context

@robertsLando Could you please help us out with a potential fix for the same.

Siburanjan commented 2 months ago

The Zwave JS version is 11.14.3

Siburanjan commented 2 months ago

@robertsLando

Siburanjan commented 2 months ago

@AlCalzone @apella12

robertsLando commented 2 months ago

sorry I was on vacation.

AlCalzone commented 2 months ago

This might just be a connectivity issue. Please read and follow https://zwave-js.github.io/node-zwave-js/#/troubleshooting/first-steps?id=first-steps to exclude the most common factors first.