zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
935 stars 198 forks source link

[bug] missing support for Inovelli Black Series Dimmer #124

Closed mcowger closed 3 years ago

mcowger commented 3 years ago

Version

Build/Run method

zwavejs2mqtt version: Release 1.0.0-alpha.2

Describe the bug Missing data for Inovelli Black Series Dimmer (see attached JSON export)>

To Reproduce Steps to reproduce the behavior: NA

Expected behavior Inovelli Black Series DImmer is recognized

Additional context

node_25.json.zip

Relevant OZW definition: https://github.com/InovelliUSA/OpenZWave/blob/master/config/inovelli/lzw31.xml

varet80 commented 3 years ago

We need this to be added on driver side!. I will take a look

varet80 commented 3 years ago

@mcowger is the red and black series the same device (happens to know)?

varet80 commented 3 years ago

@mcowger made a pull request: https://github.com/zwave-js/node-zwave-js/pull/1281

mcowger commented 3 years ago

They are not the same device. The black series is non-neutral dimmer like the red, but lacks the scene control and notifications that the red has.

On Mon, Jan 4, 2021 at 2:15 AM V Aretakis notifications@github.com wrote:

@mcowger https://github.com/mcowger is the red and black series the same device (happens to know)?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/zwave-js/zwavejs2mqtt/issues/124#issuecomment-753887241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOXCTDN2ERWGAEEQW2RTSTSYGINNANCNFSM4VOTTM5Q .

-- -- Matt

mcowger commented 3 years ago

Awesome - as soon as this is in a :dev build I'll pull it and give it a shot.

varet80 commented 3 years ago

@mcowger if you run docker, you can build your own image with a database update from Master! and test

if you clone zwavejs2mqtt and run

docker build --build-arg updateDevices=true -f docker/Dockerfile -t <image tag> .;

it will download the latest device tree and put it in container! this way you can confirm if everything is ok!

mcowger commented 3 years ago

Confirmed this correctly identified and talks to my LZW-30 devices.