search

zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
982 stars 202 forks source link

[feat] Add HTTPS control within the UI Settings #1947

Closed blhoward2 closed 3 years ago

blhoward2 commented 3 years ago

Presently, you can enable https only via an environment variable. Addon users cannot set the environment variable, though, and https is likely to be of greater interest to support cameras for SmartStart.

I think that we should add options to enable https, and to specify the SSL cert/key (to enable central certificates to be used) to the Settings UI.

If a user clicks to use the camera and we aren't running https, we should consider displaying a message to the user explaining that limitation.

myklup commented 2 years ago

I believe this feature is unintentionally locking people out of zwavejs2mqtt that didn't know it was more involved than "check this box" as seen here https://github.com/hassio-addons/addon-zwavejs2mqtt/issues/309

blhoward2 commented 2 years ago

I think this issue is caused by a few things outside our control. It appears the addon lacks openssl in the image. It also looks like ingress modifications may break this. And there is no way in the addon to specify the pem files. These are all things @frenck would need to look at.

frenck commented 2 years ago

With ingress HTTPS is provided by Home Assistant. Not zwavejs2mqtt or the addon.

blhoward2 commented 2 years ago

I edited my comment. I agree but the issue seems to be that we have a UI option for other installs to allow https. I'm not sure that we could fix that at all on our end.

blhoward2 commented 2 years ago

Maybe we could detect we're running in your docker and then disable the setting. I'm not sure what modifications you make. Is there a file or something inside the container that is unique that we could look for to know we're in your docker and not ours?

frenck commented 2 years ago

I'm not sure what modifications you make.

None.

blhoward2 commented 2 years ago

Ok. Do you build your own docker image? If so, can you touch a file inside the container for us to check for? I'm not sure how else to distinguish your image vs ours.