zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
982 stars 202 forks source link

[Bug]: Can not open network graphs since 6.5.0 #2242

Closed Botched1 closed 2 years ago

Botched1 commented 2 years ago

Checklist

Deploy method

Docker

Zwavejs2Mqtt version

6.5.0

ZwaveJS version

8.11.2

Describe the bug

The network graph page will not load since upgrading to 6.5.0.

To Reproduce

Since upgrading to z2m 6.5.0, when I go to the network graph page, it starts refreshing neighbors and then never loads the graph and eventually chrome complains about the page being unresponsive, and offers to close it. I've tried waiting >5 minutes, and the graph never shows up.

This is on a reasonably large mesh - 110 assets.

Expected behavior

Network graph page should load.

Additional context

image

robertsLando commented 2 years ago

@Botched1 Could you send me a node export please?

Also I would like to ask you if you can open the chrome dev tools and tell me if you see errors on console

Botched1 commented 2 years ago

@robertsLando

No errors on the console when going to the network map page.

image

Node dump attached. nodes_dump.zip

robertsLando commented 2 years ago

@Botched1 I just tried using your nodes and yeah webpage freezes... Seems everything on my side is processed correctly then everything freezes when calling d3 render method. I will try to see if there are ways to improve the rendiring of the graph :(

robertsLando commented 2 years ago

Getting a bit far, tring to show just 80 of your 110 nodes seems working, at first sight the problem may be there are too much edges 🤔 Each one of your node has lot of neighbors, that is good from a network side but increases computation a lot when rendiring the graph...

You have over 1200 connection to draw and that could be the root cause of the problem

robertsLando commented 2 years ago

I have just submitted https://github.com/zwave-js/zwavejs2mqtt/pull/2248

That could help partially solve your issue. With that you will be able to filter nodes to show in the graph

Botched1 commented 2 years ago

Thanks @robertsLando !

I don't really use the graph a lot, so it isn't critical to me. I only opened it in the new version to try to see the new health info, and I believe that is the only place it is available.

Botched1 commented 2 years ago

@robertsLando Just an FYI (not complaining) that I still can't open the mesh maps in 6.5.1. Basically as soon as I open the mesh tab it locks up.

I can't sometimes click one of the drop downs before it freezes, but thus far have never been able to actually select anything to narrow it down before the tab freezes.

Is there a way to specify the filter in the URL or something?

This is as close as I can get before the tab locks up: image

robertsLando commented 2 years ago

@Botched1 That's strange, on my instance the graph isn't loaded until the reload button is pressed, I need to investigate I'm sorry for that :(

Botched1 commented 2 years ago

No worries! I appreciate everything you do here.

I'm running z2m in a docker container, case it matters. I assume it shouldn't but thought I would mention it anyway.

robertsLando commented 2 years ago

@Botched1 Did you try with 6.6.0?

Botched1 commented 2 years ago

I did, and it is working now. Not sure if it was an update on your end, or a chrome update, but it worked in 6.6.0.

robertsLando commented 2 years ago

Awesome, thanks!