search

zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
974 stars 203 forks source link

Yale YRD430-ZW2 spamming network #3077

Closed murkumurdok closed 1 year ago

murkumurdok commented 1 year ago

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?

NO, my problem is NOT within Home Assistant or the ZWave JS integration

Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?

NO, my problem is NOT within Z-Wave JS UI

Checklist

Describe the bug

What causes the bug?

Adding a newly purchased YRD430-ZW2 causes the entire network to slow down and spams traffic

What do you observe?

All devices, including lock operation are significantly slowed down, debug logs are filled with entries from YRD430-ZW2. Excluding the lock returns the network to normal. Including it again reintroduces the problem. Reinteviewing and healing the node do not help.

What did you expect to happen?

I also have an older YRD256 on another door with presumably the same zwave chipset, it performs normally and does not spam the network

Steps to reproduce the behavior:

Including the YRD430-ZW2 creates the issues.

Device information

Manufacturer: Yale Model name: YRD430-ZW2 Node ID in your network: 99

How are you using node-zwave-js?

Which branches or versions?

version: node-zwave-js branch: zwave-js-ui branch: Homeassistant addon Z-Wave JS UI. Addon version 1.12.0. zwavejsui version v8.15.0

Did you change anything?

yes (please describe)

If yes, what did you change?

Included YRD430-ZW2

Did this work before?

Don't know, this is a new device

If yes, where did it work?

No response

Attach Driver Logfile

zwavejs_2023-05-04.log

AlCalzone commented 1 year ago

I notice two things:

  1. you have included the device using Security S0, not S2. Not sure if that was intentional, but if the device supports S2, you should use S2. S0 has significant overhead
  2. Most of the traffic seems to come from the Schedule Entry Lock queries which Z-Wave JS UI does since the latest version. I think they need to be optimized to not query that much.

Transferring this issue over, since the problem seems to be caused by Z-Wave JS UI.

murkumurdok commented 1 year ago

Unfortunately it only supports S0 per its zwave certification. I think only yale model numbers designated with *-ZW3 use a ZWave Plus V2 and support S2. My YRD256 also only supports S0

Also it definitely is the Schedule Entry Lock queries, I woke this morning and noticed the network was fine, no more spamming in the logs. To test, I restarted the Z-Wave JS UI and the problems started again as the logs were filling with Schedule Entry Lock queries for each code slot. It took almost 30 minutes for it go through all 250 code slots, but once it was finished, everything was fine.

robertsLando commented 1 year ago

@murkumurdok I opened a PR to fix this, see #3078 .