zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
971 stars 203 forks source link

Priority route not visible with "star" #3492

Closed Beer17HWAM closed 3 months ago

Beer17HWAM commented 10 months ago

My friend and I both have the same zwave-js-ui 9.3.2 version. I can see all the Priority routes, visible with "star" in the network graph. My friend isn't seeing any "star".

How is that posible?

robertsLando commented 10 months ago

But did you set that priority route manually or what? Firstly switch to latest 9.6.0

Beer17HWAM commented 10 months ago

Yes we both added routes manually. We did mainly the same things. Just add some priority routes. I use those to have a more stable situation. Since I use priority routes it works better. My friend want those too but isn't seeing any "stars". I know that there are newer versions but my friend hasn't got any "stars" for months now. And I do. The only difference is I run a separate docker and my friend has the hassio addon. Very strange, we use the same version and the same hardware zwave dongle.

robertsLando commented 10 months ago

This explanation alone doesn't give me enough context to tell you what's going on there, what I can think is that for some reason he did a route update and the priority route has been removed and it became a LWR route instead

Beer17HWAM commented 10 months ago

No, the priority route isn't removed. It's still there. But I see all small "stars" in the network graph view but in his network graph no starts are visible.

robertsLando commented 10 months ago

I dunno, if your friend has such issue he should upload nodes json so I can give it a look

Beer17HWAM commented 10 months ago

nodes_dump.json This is his json export.

robertsLando commented 10 months ago

The only one with an application route set is node 22 and it has:

"lwr": {
        "protocolDataRate": 2,
        "repeaters": [
          3
        ]
 },
"nlwr": {
        "protocolDataRate": 3,
        "repeaters": [],
        "rssi": -54,
        "repeaterRSSI": []
},
"applicationRoute": {
      "repeaters": [],
      "routeSpeed": 3
    },

Does he see the star on the link from 22 to the controller? I have a feel if he doesn't it could be because the nlwr mathes the application route

Beer17HWAM commented 10 months ago

He doesn't see any star, no stars at all. And when he sets more priority routes they don't stick. After he sets a priority route and leave the popup and click the node again the priority route is gone. Only on node 22 it stays. Setting priority routes is not going well and he doesn't see any star.

Nodes with priority: Node 3, 5, 32, 46, 31, 45, 22 (also return)

robertsLando commented 10 months ago

I need driver logs that show the tries of setting a priority route

jeroen84s commented 10 months ago

zwave-js-ui-store.zip Are those the correct log file? If not, can you explain how to create the driver logs?

robertsLando commented 10 months ago

Them are correct. Thanks. I need to ask @AlCalzone to review them. Anywat could you also try to upgrade to latest ? 9.6.0?

robertsLando commented 10 months ago

I only see a successfull try in logs and no fail:

2023-12-21T10:31:23.954Z DRIVER » [REQ] [SetPriorityRoute]
                                    node ID:     24
                                    repeaters:   none
                                    route speed: 100k
2023-12-21T10:31:23.957Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.964Z SERIAL « 0x01050193180171                                                     (7 bytes)
2023-12-21T10:31:23.966Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.970Z DRIVER « [RES] [SetPriorityRoute]
                                    success: true
2023-12-21T10:31:23.975Z CNTRLR   Retrieving priority route to node 24...
2023-12-21T10:31:23.981Z SERIAL » 0x010400921871                                                       (6 bytes)
2023-12-21T10:31:23.983Z DRIVER » [REQ] [GetPriorityRoute]
                                    node ID: 24
2023-12-21T10:31:23.986Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.988Z SERIAL « 0x010a0192181000000000036d                                          (12 bytes)
2023-12-21T10:31:23.990Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.992Z DRIVER « [RES] [GetPriorityRoute]
                                    node ID:     24
                                    route kind:  Application
                                    repeaters:   none
                                    route speed: 100k
jeroen84s commented 10 months ago

I can't update to a newer version, because I use hassio addon

Beer17HWAM commented 10 months ago

Again, in my opinion it has nothing to do with the version because I use the same version in a docker. I see beautiful "stars". :-)

AlCalzone commented 10 months ago

@robertsLando how are the stars drawn? Are they text/emojis or SVG?

Can we somehow confirm whether Z-UI sees the routes as priority routes? In other words, can we confirm whether this is a pure display issue?

Beer17HWAM commented 10 months ago

networkgraph See jpg. This is mine. The network graph of @jeroen84s isn't displaying any "star".

Beer17HWAM commented 10 months ago

@robertsLando how are the stars drawn? Are they text/emojis or SVG?

Can we somehow confirm whether Z-UI sees the routes as priority routes? In other words, can we confirm whether this is a pure display issue?

It's not only a display issue. The priority routes @jeroen84s is making are not saved. He can set a route (and back) but after closing the node and opening the node the priority route is gone.

AlCalzone commented 10 months ago

Ok I'll try to look at the logs tonight. Maybe I'll see something.

robertsLando commented 10 months ago

@AlCalzone them are SVG and as said I don't see any error in the logs he uploaded above. Anyway IMO this seems to me a display issue but I may be wrong

Beer17HWAM commented 10 months ago

Not only a display issue!! I already said: The priority routes @jeroen84s is making are not saved. He can set a route (and back) but after closing the node and opening the node the priority route is gone.

AlCalzone commented 10 months ago

@jeroen84s is showing that several communication attempts succeed using the priority routes, e.g.

2023-12-21T10:30:05.168Z DRIVER « [REQ] [SendData]
                                    callback id:            1
                                    transmit status:        OK, took 90 ms
                                    routing attempts:       3
                                    protocol & route speed: Z-Wave, 40 kbit/s
                                    routing scheme:         Priority Route
                                    ACK RSSI:               -68 dBm
                                    ACK channel no.:        1
                                    TX channel no.:         1

and that several priority routes are known, e.g.:

2023-12-21T10:30:07.275Z DRIVER « [RES] [GetPriorityRoute]
                                    node ID:     46
                                    route kind:  Application
                                    repeaters:   5
                                    route speed: 100k

Also, assigning the routes works too:

2023-12-21T10:31:23.940Z CNTRLR   Setting priority route to node 24...
2023-12-21T10:31:23.944Z DRIVER   all queues busy
2023-12-21T10:31:23.952Z SERIAL » 0x010900931800000000037e                                            (11 bytes)
2023-12-21T10:31:23.954Z DRIVER » [REQ] [SetPriorityRoute]
                                    node ID:     24
                                    repeaters:   none
                                    route speed: 100k
2023-12-21T10:31:23.957Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.964Z SERIAL « 0x01050193180171                                                     (7 bytes)
2023-12-21T10:31:23.966Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.970Z DRIVER « [RES] [SetPriorityRoute]
                                    success: true
2023-12-21T10:31:23.975Z CNTRLR   Retrieving priority route to node 24...
2023-12-21T10:31:23.981Z SERIAL » 0x010400921871                                                       (6 bytes)
2023-12-21T10:31:23.983Z DRIVER » [REQ] [GetPriorityRoute]
                                    node ID: 24
2023-12-21T10:31:23.986Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.988Z SERIAL « 0x010a0192181000000000036d                                          (12 bytes)
2023-12-21T10:31:23.990Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.992Z DRIVER « [RES] [GetPriorityRoute]
                                    node ID:     24
                                    route kind:  Application
                                    repeaters:   none
                                    route speed: 100k

What might be happening: This node is a sleeping node, so there are no route statistics yet to draw the route. I think Z-UI isn't handling the case where there are no statistics, but the priority route is known. @robertsLando

Beer17HWAM commented 10 months ago

@AlCalzone Can you see the routes back also? The route back isn't shown in the Node when you open it again in the Network Graph after setting it. And why do I see "stars" and @jeroen84s not? I think it's all very strange. Why this complete other reaction than I have. I also set priority routes with sleeping Nodes. Also setting prio routes between Nodes with power (non sleeping Nodes) isn't displaying any "star". Am I the only one with visible "stars"? Lucky guy I am. ;-)

AlCalzone commented 10 months ago

The routes back require communication with the node, which doesn't happen when the node is asleep. It has to be woken up for the return route to actually be saved. After that there has been communication with the node, which means there are routing statistics, which means this display bug in Z-Wave JS UI probably won't trigger anymore for that node.

As for routes to and from powered nodes: I need to see a log of that.

jeroen84s commented 10 months ago

Your vision about the sleeping nodes looks correct. Both wall plugs has a priority route (also return route). And the star in is not showing up in the graphic

Beer17HWAM commented 10 months ago

Your vision about the sleeping nodes looks correct. Both wall plugs has a priority route (also return route). And the star in is not showing up in the graphic

No stars. Maybe with Christmas. Just wait. ;-)

nmpu commented 9 months ago

I've never seen stars either. I saw the legend, but never knew what I was missing. My priority routes are still there when I drill down and the diagram has changed-- just no stars. All my priority routes involve powered devices. This is one of those features that is probably rarely used or missed. BTW, the 'Node properties' popup gets clipped by Daniel's donation footer. The [Ping] button is obscured.

robertsLando commented 9 months ago

@nmpu can't you just drag the dialog a bit higher? it can be moved where you want

nmpu commented 9 months ago

@robertsLando yes, that does work. I'm not used to web dialogs being moveable. Pretty fancy. Once you know there's a [Ping] button, you can blindly click on the top edge.

Should I also see stars in the app? I don't.

The 'Show return routes' and 'Show priority routes' checkboxes get disabled in the global view, but are enabled in the node view. However, the previous state remains when grayed. Is that how it's supposed to work?

Beer17HWAM commented 9 months ago

Graph of jeroen84s: With the latest HAOSS zwave still NO STARS. And a lot of gray nodes (disconnected). But they work without problems.

WhatsApp Image 2024-01-23 at 09 19 10

Beer17HWAM commented 9 months ago

I also have one gray node but this one is also working without problems. And I have stars, lucky me!

WhatsApp Image 2024-01-23 at 09 20 27

nmpu commented 9 months ago

@Beer17HWAM Do you see stars in the app? I'm not sure that's even a thing.

Beer17HWAM commented 9 months ago

@Beer17HWAM Do you see stars in the app? I'm not sure that's even a thing.

Yes, it's a sign for priority routes. But not all people have those stars in their Graph. I allways had them.

nmpu commented 9 months ago

@Beer17HWAM It can't be a display issue. I'm running HAOS as an x86 VM. The install is only about a month old. I recently switched from 500 series to 800 series radio. I never saw stars in either case. I have 40 nodes. You have fewer. Your friend is in the middle. Does something happen with newer installs? Larger networks? I think it's a configuration setting.

nmpu commented 9 months ago

@Beer17HWAM how does your graph change if you uncheck 'Show priority routes' in the drop-down section?

Beer17HWAM commented 9 months ago

@Beer17HWAM how does your graph change if you uncheck 'Show priority routes' in the drop-down section?

Is grayed out, cannot disable 'Show priority routes'.

WhatsApp Image 2024-01-23 at 09 57 31

nmpu commented 9 months ago

If 'Node properties' is shown, the checkboxes will be ungrayed. It's not clear what's going on there. Do you see stars in the node (zoomed) view? You know what I'm trying to do right? I'm trying to make you lose your stars. :)

Beer17HWAM commented 9 months ago

If 'Node properties' is shown, the checkboxes will be ungrayed. It's not clear what's going on there. Do you see stars in the node (zoomed) view? You know what I'm trying to do right? I'm trying to make you lose your stars. :)

I'm not able to "remove" the stars. I can toggle the switches, see results. In the main Graph stars never disappear. See all the 4 the possibilities:

WhatsApp Image 2024-01-23 at 10 30 57 WhatsApp Image 2024-01-23 at 10 30 46 WhatsApp Image 2024-01-23 at 10 30 26 WhatsApp Image 2024-01-23 at 10 30 13

robertsLando commented 9 months ago

I have a feel that the start issue is something browser related as it is passed as an svg... Could I ask you to open dev tools and see in network tab if the svg request is fullfilled correctly?

Beer17HWAM commented 9 months ago

The file is simply not available!!

WhatsApp Image 2024-01-23 at 11 52 55

Beer17HWAM commented 9 months ago

In my case it is available:

WhatsApp Image 2024-01-23 at 11 54 43

Beer17HWAM commented 9 months ago

Why is the star.svg file not available in the hassio add-in version?? I still have it in my separate docker environment, not as add-in.

robertsLando commented 9 months ago

Ok so seems an issue with the hass addon, maybe @frenck could help here? Could it be a proxy issue maybe?

Beer17HWAM commented 9 months ago

The star.svg file not available in the hassio add-in version. That's why nobody with hassio has stars. I run a separate docker environment outside Home Assistant that's why I have the star.

https://github.com/hassio-addons/addon-zwave-js-ui :

WhatsApp Image 2024-01-23 at 15 46 02

Beer17HWAM commented 9 months ago

The https://github.com/zwave-js/zwave-js-ui version has a star:

WhatsApp Image 2024-01-23 at 15 51 50

robertsLando commented 9 months ago

star should be in dist/star.svg and that dist folder is only created during the build step. I think it is there but for some reason the addon proxy doens't serve it correctly

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

Beer17HWAM commented 6 months ago

It's still not fixed in the latest release. Please fix.

robertsLando commented 6 months ago

I sincerly have no clue how to fix this as it's working on all my instances

Beer17HWAM commented 6 months ago

The star.svg is not available in his environment. How can he fix this?

robertsLando commented 6 months ago

I cannot help so much as the error seems to be on addon side, only @frenck could help here and I already tagged him