Smart Start Manufacture/Label/Description Blank for items attached to nodes

zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify

https://zwave-js.github.io/zwave-js-ui

MIT License

919 stars 196 forks source link

Smart Start Manufacture/Label/Description Blank for items attached to nodes #3677

Closed zackbcom closed 2 months ago

zackbcom commented 2 months ago

Checklist

[X] I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.11.1.9e7d24e

ZwaveJS version

12.5.5

Describe the bug

I am unable to see / update the Manufacture/Label/Description on smart start assets that are attached to a node.

To Reproduce

Not sure if related to upgrade from 9.9.1, or what version of node-js the devices were added with.

Expected behavior

Should show related information from node

Additional context

No response

robertsLando commented 2 months ago

@AlCalzone I'm wondering if this is a regression on driver side because I can see them on my end (for an old device), I think this happens only for newly added Smart Start codes.

AlCalzone commented 2 months ago

The device manufacturer/label for SmartStart entries can (but doesn't have to) be included in the QR code. When it is, it is also included in the SmartStart provisioning entry that Z-Wave JS saves in its cache. This is what Z-Wave JS UI displays there AFAIK.

The information in the second screenshot comes from our device config files.

So they aren't related per se. I suppose it makes sense to display the information from the Node instance there if the provisioning entry doesn't have a manufacturer/label and the node is already included.

robertsLando commented 2 months ago

Oh ok I wasn't aware of this, I can look at that in #3674

Botched1 commented 2 months ago

Oh ok I wasn't aware of this, I can look at that in #3674

One thing I would add is that I think the "Protocol" field should also populate after a device has been paired, too.

See screenshot. The "Computer Room Door" SmartStart entry was manually added (not scanned from QR code). Long Range boot mode was selected, and the device successfully paired as LR (as noted by the device ID#), yet the Protocol is blank.

robertsLando commented 2 months ago

Ok follow updates on #3674