zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
950 stars 205 forks source link

For Z-Wave LR Devices Diagnose / Health Check Should Not Allow Health Checks Against anything except the controller #3681

Closed Botched1 closed 5 months ago

Botched1 commented 5 months ago

Checklist

Deploy method

Docker

Z-Wave JS UI version

9.11.1.9e7d24e

ZwaveJS version

12.5.5

Describe the bug

Health Check / Diagnose will allow you to attempt a health check between a Z-Wave LR device and other devices, even though Z-Wave LR devices can't talk directly to anything except the controller.

To Reproduce

From Network Graph view and selecting a Z-Wavew LR end device then click the blue DIAGNOSE button.

Run a health check against any node, except the controller.

It will fail as Z-Wave LR devices can not communicate with other end devices, so should not be allowed at all.

Expected behavior

You should not be able to health check a Z-Wave LRT end device against anything other than the controller.

Additional context

No response

robertsLando commented 5 months ago

Correct, will fix

robertsLando commented 5 months ago

@robertsLando You can start by hiding the neighbors display when doing health checks on a LR device

cc @AlCalzone I will do it here