zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
984 stars 201 forks source link

MQTT Discovery: Light objects should report `supported_color_modes` #3894

Closed dwmw2 closed 2 months ago

dwmw2 commented 2 months ago

Checklist

Deploy method

Manually built (git clone - npm run build - npm install

Z-Wave JS UI version

9.18.1

ZwaveJS version

13.3.0

Describe the bug

Light objects are advertised for MQTT AutoDiscovery using an out-of-date method.

The documentation at https://developers.home-assistant.io/docs/core/entity/light/ says that all lights should report supported_color_modes, including those which only support ColorMode.BRIGHTNESS or ColorMode.ONOFF.

To Reproduce

Use a Z-Wave light/dimmer device, and see the contents of its discovery topic.

Expected behavior

I expected to see

  supported_color_modes: ["brightness"],

or

  supported_color_modes: ["onoff"],

in the device configuration object.

Additional context

No response

robertsLando commented 2 months ago

@dwmw2 Prepared a fix on #3895

dwmw2 commented 2 months ago

That was fast. Thanks!