zwbetz-gh / cupper-hugo-theme

An accessibility-friendly Hugo theme, ported from the original Cupper project.
https://cupper-hugo-theme.netlify.app/
MIT License
301 stars 190 forks source link

Unfixed navigation on dark mode toggle (Firefox) #11

Closed pcsteppan closed 4 years ago

pcsteppan commented 5 years ago

Description When in dark mode, the navigation on the left no longer sticks as the user scrolls, it gets stuck at the top.

To Reproduce

Steps to reproduce the behavior:

  1. Open demo in firefox on desktop
  2. Toggle darkmode on
  3. Scroll down to see unfixed nav

Expected behavior The navigation, like in the light mode, should follow the user as they scroll up and down the page.

System info

Screenshot Screenshot_2019-06-22 Cupper

zwbetz-gh commented 5 years ago

Thanks for the report. As you noted, I can only reproduce this in Firefox, with dark mode on. Am investigating.

rignato commented 4 years ago

Hello I have created a PR for this issue, please check it out. #22

zwbetz-gh commented 4 years ago

Fixed in https://github.com/zwbetz-gh/cupper-hugo-theme/pull/22 by @rignato