zwbetz-gh / cupper-hugo-theme

An accessibility-friendly Hugo theme, ported from the original Cupper project.
https://cupper-hugo-theme.netlify.app/
MIT License
301 stars 190 forks source link

About scroll bar in homepage. #18

Closed gapplef closed 4 years ago

gapplef commented 4 years ago

Describe the bug The homepage will always need scroll to shown the footer, even when that is little content on the page, leave out a long range of space. You can see this from the demo site. I don't know if this should consider a bug. But is it possible to make the homepage fit the screen and show all content.

zwbetz-gh commented 4 years ago

The scroll behavior is on purpose.

gapplef commented 4 years ago

@zwbetz-gh thanks for you help.

And I found the correct line should be modified is the following one, as a reference for any one may also want to change the default behaviour. https://github.com/zwbetz-gh/cupper-hugo-theme/blob/315fe6a8d9b31b527b47d6506ead7f0ee97799a9/assets/css/template-styles.css#L550

zwbetz-gh commented 4 years ago

@gapplef good catch 👍