search

zwbetz-gh / cupper-hugo-theme

An accessibility-friendly Hugo theme, ported from the original Cupper project.
https://cupper-hugo-theme.netlify.app/
MIT License
301 stars 190 forks source link

Screen reader issues #34

Closed devinprater closed 4 years ago

devinprater commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

Using a screen reader, one cannot tell the difference between submitted date and updated date on articles, and headings that are in the table of contents have a link after them that just goes back to that same heading, effectively going nowhere.

To Reproduce Steps to reproduce the behavior:

  1. Go to [https://devinprater.github.io/2020-04-16-writing-richly/](This page on my site).
  2. Using a screen reader, notice that "Apr 16, 2020 " and "Jun 9, 2020" have no other text defining them as the submit and update date.
  3. Scroll down to the "What’s this rich text and who needs all that?" heading. After that section, you'll find a link called "This What’s this rich text and who needs all that? section". That is redundant, and the link just puts focus back on that heading.

Expected behavior A clear and concise description of what you expected to happen.

I expect the "published" and "updated" text to set apart the first and second date, and there to be no link after headings that don't practically do anything.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Thanks so much for this theme. There are only a few that even focus on accessibility, and I hope this theme is even made for blogging in the first place, as there seem to be a few that are for other purposes.

zwbetz-gh commented 4 years ago

Thanks for bringing this up. It has been fixed in https://github.com/zwbetz-gh/cupper-hugo-theme/commit/5e2ff37e94d1229ab801a7f2ef3aef3513726127.

zwbetz-gh commented 4 years ago

By the way, I'm digging your blog.

devinprater commented 4 years ago

Thanks so much! Now if I can get tags to work, my transfer from Jekyll to Hugo will be pretty complete. The tags page:

https://devinprater.github.io/tags/ https://devinprater.github.io/tags/

Doesn’t show any tags or pages of those tags. If it does show them visually, that may be another accessibility issue.

On Jun 10, 2020, at 8:06 PM, zwbetz-gh notifications@github.com wrote:

By the way, I'm digging your blog.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zwbetz-gh/cupper-hugo-theme/issues/34#issuecomment-642345085, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTTL2JG5ES7MDB3LGDTRWAU2RANCNFSM4N24W4WQ.

devinprater commented 4 years ago

And now the tags works… somehow. Yay! Now I can start working on more content! The only problem left is the link after the heading. It went from the heading name to saying, for example, on https://devinprater.github.io/2020-04-16-writing-richly/ https://devinprater.github.io/2020-04-16-writing-richly/

"2020-04-16-writing-richly”

After the "What’s this rich text and who needs all that?” heading.

On Jun 11, 2020, at 11:36 AM, Devin Prater d.prater@me.com wrote:

Thanks so much! Now if I can get tags to work, my transfer from Jekyll to Hugo will be pretty complete. The tags page:

https://devinprater.github.io/tags/ https://devinprater.github.io/tags/

Doesn’t show any tags or pages of those tags. If it does show them visually, that may be another accessibility issue.

On Jun 10, 2020, at 8:06 PM, zwbetz-gh <notifications@github.com mailto:notifications@github.com> wrote:

By the way, I'm digging your blog.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zwbetz-gh/cupper-hugo-theme/issues/34#issuecomment-642345085, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTTL2JG5ES7MDB3LGDTRWAU2RANCNFSM4N24W4WQ.

zwbetz-gh commented 4 years ago

Good deal on the tags working. If that is indeed an issue, you'll need to open a separate GitHub issue here.

What you may be seeing on the heading links is a helper link that let's you quickly get the url fragment from that point in the page.

I can look into making that configurable, then you could turn it off in your case.

devinprater commented 4 years ago

Yeah, the tags are fixed. The “helper link” I think should be configurable. thanks so much.

On Jun 11, 2020, at 12:08 PM, zwbetz-gh notifications@github.com wrote:

Reopened #34 https://github.com/zwbetz-gh/cupper-hugo-theme/issues/34.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zwbetz-gh/cupper-hugo-theme/issues/34#event-3435139694, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTSXPLK737CNBBWQL63RWEFR3ANCNFSM4N24W4WQ.

zwbetz-gh commented 4 years ago

Hiding header links is now configurable. See https://github.com/zwbetz-gh/cupper-hugo-theme/commit/e9a24f95ec8e51a3e1ac643249ec1333321772d2

Pull the latest theme changes, then add this to your config:

params:
  hideHeaderLinks: true
devinprater commented 4 years ago

Thanks so much, it works!

On Jun 11, 2020, at 1:14 PM, zwbetz-gh notifications@github.com wrote:

Closed #34 https://github.com/zwbetz-gh/cupper-hugo-theme/issues/34.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zwbetz-gh/cupper-hugo-theme/issues/34#event-3435367903, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUMTTUJTQSEVGODYC5L453RWENIHANCNFSM4N24W4WQ.

zwbetz-gh commented 4 years ago

Good deal 👍