search

zwbetz-gh / cupper-hugo-theme

An accessibility-friendly Hugo theme, ported from the original Cupper project.
https://cupper-hugo-theme.netlify.app/
MIT License
301 stars 190 forks source link

Umlaut characters broken in headlines on Firefox #40

Closed yayachiken closed 4 years ago

yayachiken commented 4 years ago

Describe the bug German Umlaut characters and Eszett (ÄÖÜäöüß) do not render in headline font in Firefox.

To Reproduce Steps to reproduce the behavior:

  1. Create a page with the Text "ÄAÖOÜUäaöoüoßss"
  2. Open page in Chrome, text renders fine.
  3. Open page in Firefox (version 78.0.2 on Linux), Umlaut characters render in a fallback font.

Expected behavior Chrome and Firefox render the fonts the same, especially the special characters should fit in.

Screenshots

Example 1 from a real page (note the headlines): umlaut-error

Example 2 from fontdrop.info: umlaut-error2

Desktop (please complete the following information):

Additional context I was also able to reproduce the behaviour by uploading the woff font to https://fontdrop.info/ and putting in the above mentioned text in the "Type yourself" field, maybe only the woff font is broken and woff2 works?

zwbetz-gh commented 4 years ago

I am not familiar when it comes to multilingual font support... so:

Do you think that Firefox itself has an issue, and this is why Chrome shows it fine?

Or, do you think that this theme has an issue, and Chrome is doing some silent error handling?

zwbetz-gh commented 4 years ago

I am not familiar when it comes to multilingual font support... so:

Do you think that Firefox itself has an issue, and this is why Chrome shows it fine?

Or, do you think that this theme has an issue, and Chrome is doing some silent error handling?

@yayachiken ?

zwbetz-gh commented 4 years ago

Closing this issue for reasons:

yayachiken commented 4 years ago

Sorry that I do not immediately respond within my own leisure time.

The root cause is as I said already: The fonts packaged with the theme are broken. Redownloading the Miriam Libre Bold font from Google helps, the font size gets increased by about 5 kB per file (woff/woff2) so that's a bit of a tradeoff for better i18n (it seems that other European languages are affected by the broken fonts as well.)

I would have filed a PR eventually, but if you are that impatient, you will have to do that by yourself now. The information I gave should be well sufficient to fix this on your own.

Again sorry for wasting your time.

zwbetz-gh commented 4 years ago

You opened the issue 16 days ago. Keep in mind this is my leisure time as well.

If I came off harsh, that is not my intent. If someone were to submit a PR for this, I would gladly review it.

zwbetz-gh commented 4 years ago

Fixed by @fkohrt in https://github.com/zwbetz-gh/cupper-hugo-theme/pull/43

Please verify @yayachiken

yayachiken commented 4 years ago

I have not tried out this specific commit, but it seems @fkhort implemented the fix I described (redownloading fonts) , so this should be alright.