search

zwbetz-gh / cupper-hugo-theme

An accessibility-friendly Hugo theme, ported from the original Cupper project.
https://cupper-hugo-theme.netlify.app/
MIT License
301 stars 190 forks source link

Do not set overscroll-behavior to none for x axis #79

Closed ahaltindis closed 2 years ago

ahaltindis commented 2 years ago

Hello!

(First of all thanks for porting this theme to Hugo, I love it.)

When I was checking out the theme from the demo page (https://cupper-hugo-theme.netlify.app/), I noticed that I can't go back and forward in the history from touch-pad (swipe left/right) on MacOS. Considering this is very natural movement on a webpage, I immediately felt blocked by lack of this.

After checking the CSS, I noticed that, this is because of disabling overscroll-behavior in both X and Y axis. I see the necessity of this in Y axis, as bounce effect doesn't look great on top border line, but I couldn't see any reason to disable it in X axis as overflow should not be possible.

Therefore, I just think it should be a good balance to not disable this behavior in X axis. I tested this in both Firefox and Chrome, and the expected behavior is started working after this fix. Safari wasn't impacted by this at all.

Thanks.

zwbetz-gh commented 2 years ago

Hi @ahaltindis - Thank you for the kind words.

I agree with your change.

Thank you for documenting it well and listing the test cases.