search

zwbetz-gh / cupper-hugo-theme

An accessibility-friendly Hugo theme, ported from the original Cupper project.
https://cupper-hugo-theme.netlify.app/
MIT License
301 stars 190 forks source link

Fix body font size change (fixes #82) #83

Closed jberryman closed 1 year ago

jberryman commented 1 year ago

The bug was introduced in be6536778d36eaa223cf492d18af3d4dd9163104 , which applied the block to body

zwbetz-gh commented 1 year ago

Hi @jberryman thanks for this PR.

So https://github.com/zwbetz-gh/cupper-hugo-theme/commit/be6536778d36eaa223cf492d18af3d4dd9163104 was part of the fix for a previous issue, https://github.com/zwbetz-gh/cupper-hugo-theme/issues/77

Your PR addresses the https://github.com/zwbetz-gh/cupper-hugo-theme/issues/82 you opened.

But in order to prevent a regression on https://github.com/zwbetz-gh/cupper-hugo-theme/issues/77, add this css as well, right below the block you edited:

html,
body {
    overscroll-behavior-y: none;
}
jberryman commented 1 year ago

ah right, that makes sense. Closing in favor of https://github.com/zwbetz-gh/cupper-hugo-theme/pull/84