search

zwbetz-gh / zwbetz

My personal site
https://zwbetz.com/
MIT License
16 stars 5 forks source link

`Convert HEIC Images to JPG` Homebrew install flags no longer accurate, or not accurate on WSL #3

Closed mambocab closed 3 years ago

mambocab commented 3 years ago

Describe what the issue is

The imagemagick installation instructions in Convert HEIC Images to JPG did not work for me on WSL when I tried to install today: the command brew install imagemagick --with-libheif failed with Error: invalid option: --with-libheif.

It seems that as of 2019, HEIC support is built into the brew-installed imagemagick suite by default. I confirmed this when I ran brew install imagemagick, no flags, and saw the following:

==> Installing dependencies for imagemagick: libpng, freetype, jpeg, libtiff, libxml2, gettext, util-linux, fontconfig, libidn, ghostscript, aom, libde265, pcre, sqlite, glib, docbook, docbook-xsl, gnu-getopt, libgpg-error, libgcrypt, libxslt, xmlto, shared-mime-info, x265, libheif, liblqr, libomp, libtool, little-cms2, ilmbase, openexr, openjpeg and webp

Note the libheif dependency.

Further (and more importantly), when I ran mogrify -format jpg *.heic as suggested in your post, it worked with imagemagick installed as above.

So, YMMV on macos, but I believe that that flag is no longer necessary and can be removed from the post.

Thanks for sharing these instructions; they showed up high in the google search results and I'm glad they did.

zwbetz-gh commented 3 years ago

Hi @mambocab - thank you for the detailed issue 🚀 .

(I wish every issue against my repos was this detailed).

Turns out some things have changed since 2018, ha. I can reproduce the error on my Mac.

This has been fixed in https://github.com/zwbetz-gh/zwbetz/commit/971cfdf4c0daa92ba86033082fd86f7c96246c0c

mambocab commented 3 years ago

Turns out some things have changed since 2018, ha.

So I've heard.

I wish every issue against my repos was this detailed.

So do I! It's the least I can do to say thanks for sharing.

Thank you!