issue in chroot_holoiso.sh that delete all data.

grimlokason commented 9 months ago

Your Issue:

All the data on my disk has been deleted while using the chroot script on the desktop of the installation iso. If we take a look at https://github.com/zweiler2/HoloISO_Tweaked/blob/Tweaked_5.x/airootfs/etc/holoinstall/post_install/chroot_holoiso.sh , We can see that there is a sudo rm -rf ${MOUNT_DIR} , even if there is a check before, it seems that it failed in my case after launching the script twice. I'm afraid that i'm won't be able to reproduce the issue.

Your device's full specs

not related

Your OS version (`cat /etc/os-release | grep VARIANT_ID | cut -d '"' -f 2`):

has been deleted :'(

Have you updated your installation recently?

Just after a reinstallation with a fresh usb key with the last iso without deleteing my home dir

zweiler2 commented 9 months ago

I'm so sorry. Something like this should never happen. I'll fix this asap.

grimlokason commented 9 months ago

Hi !

Just spotted the issue. it's the "umount -l" :


           Lazy unmount. Detach the filesystem from the file hierarchy
           now, and clean up all references to this filesystem as soon
           as it is not busy anymore.

           A system reboot would be expected in near future if you’re
           going to use this option for network filesystem or local
           filesystem with submounts. The recommended use-case for
           umount -l is to prevent hangs on shutdown due to an
           unreachable network share where a normal umount will hang due
           to a downed server or a network partition. Remounts of the
           share will not be possible.```

NB : I'll test extundelete this evening ^^'

zweiler2 commented 9 months ago

Fixed by this commit, but one "i" too much and GH didn't close this automatically oops ;)

zweiler2 / HoloISO_Tweaked