Address issue with comment handling in the splitter

zweilove / css_splitter

Gem for splitting up stylesheets that go beyond the IE limit of 4095 selectors, for Rails 3.1+ apps using the Asset Pipeline.

MIT License

160 stars 47 forks source link

Address issue with comment handling in the splitter #5

Closed christoffer closed 11 years ago

christoffer commented 11 years ago

This pull request will fix an issue that destroys CSS files that contain protocol independent urls (for example: background-image: url(//assets.myserver.com/asset.png)).

It also addresses the issue of wrongfully parsed multiline comments.

Not that this changes the current behavior as it will no longer remove // comments. This should be the correct behavior since // is not a valid CSS comment.

jhilden commented 11 years ago

Looks good. And thank you especially for the great test cases! Our lib ist still dramatically "undertested".