search

zweilove / css_splitter

Gem for splitting up stylesheets that go beyond the IE limit of 4095 selectors, for Rails 3.1+ apps using the Asset Pipeline.
MIT License
160 stars 47 forks source link

Keep @keyframes from getting split up #55

Closed rubenswieringa closed 9 years ago

rubenswieringa commented 9 years ago

This makes sure that when a @keyframes block starts before the 4096-rule limit and ends after, it won't be split up.

If there is anything else you need to me to do to have this PR merged then please do let me know :)

jhilden commented 9 years ago

I didn't have a chance yet to look at this, but it is on my list. If anybody else has tried and/or reviewed this yet, feedback is always welcome.

scriptfans commented 9 years ago

great, It solved my problem, thanks.

rubenswieringa commented 9 years ago

@jhilden I would like to make this as effortless for you as possible, what would you want to see in this PR for this to be merged? Any further tests? There seem to be a few people who have been running into problems with keyframes in their stylesheet.

jhilden commented 9 years ago

Besides the 2 comments above the code looks good to be merged for me.

Thanks a lot for tackling this @rubenswieringa

rubenswieringa commented 9 years ago

@jhilden the 2 things are taken care of, let me know if there is anything else :)

jhilden commented 9 years ago

Thanks for the PR.

(I just hope that those legacy IEs are counting keyframe selectors the same way we are)

rubenswieringa commented 9 years ago

No problem, thanks for merging. I don't have the time for it right now, but it shouldn't be too hard to put up a quick test and run it through browserstack, right?

rubenswieringa commented 9 years ago

Also, could you make a new release so I can update my Gemfile?

jhilden commented 9 years ago

I released version 0.4.2