zweilove / css_splitter

Gem for splitting up stylesheets that go beyond the IE limit of 4095 selectors, for Rails 3.1+ apps using the Asset Pipeline.
MIT License
160 stars 47 forks source link

Fix regex comparison for media queries #57

Closed ernestoacevedo closed 8 years ago

ernestoacevedo commented 9 years ago

Hi, I wanna let you know that the gem wasn't working when there was a whitespace character before the @media rule so I change it.

willbutler commented 9 years ago

We were having the same issue. Thanks @ernestoacevedo!

jhilden commented 9 years ago

Thanks a lot for the fix @ernestoacevedo I'm happy to merge it, but it would be awesome if you could add a failing test case for your bugfix. The information provided by @cbeckr here (https://github.com/zweilove/css_splitter/issues/53#issuecomment-156831674) might be helpful to you.

danielhusar commented 8 years ago

+1

gareth commented 8 years ago

@jhilden :white_check_mark:

jhilden commented 8 years ago

thanks @gareth

jhilden commented 8 years ago

I released version 0.4.3 that includes this bugfix.