search

zweilove / css_splitter

Gem for splitting up stylesheets that go beyond the IE limit of 4095 selectors, for Rails 3.1+ apps using the Asset Pipeline.
MIT License
160 stars 47 forks source link

Fix test case && issue of exceeding selectors #74

Open khiav223577 opened 8 years ago

khiav223577 commented 8 years ago

Hi, I'm trying to fix https://github.com/zweilove/css_splitter/issues/72#issue-183939840 and https://github.com/zweilove/css_splitter/pull/71 I modify some test cases for the 1st issue and add a regression test case for the 2nd. I try hard to make sure this PR pass all the tests, but have trouble with some of them ( https://github.com/zweilove/css_splitter/issues/72#issuecomment-255519290 ). Could you help me?

jhilden commented 7 years ago

Hi reoy, thanks for your PR. I meant to take a look at it, but didn't find the time.

Maybe it makes sense to ping the author(s) of the code you changed to answer your questions?

Concerning the issue with the tests, can you maybe elaborate what the issue is and what you already tried? I think that could increase the change of somebody being able to help.

khiav223577 commented 7 years ago

What I want to change mainly is this line: https://github.com/zweilove/css_splitter/pull/74/files#diff-3b8e9eb6bd155a54d793812eccd2b02cL15 because it splits the rules wrongly, for example: 

"@media (min-width 768px){.a{}}".scan(/[^}]*}/).to_a 
# => ["@media (min-width 768px){.a{}", "}"] `

The author of the code is you. (https://github.com/zweilove/css_splitter/commit/6be6a2b1751ad05980f2938bcf582a678b5aac0e#diff-3b8e9eb6bd155a54d793812eccd2b02cR15) Maybe you can explain this line for me when you have time.