search

zweitag / middleman-images

Resize and optimize images for Middleman
MIT License
17 stars 3 forks source link

image_path doesn’t seem to work #19

Closed lucasdinonolte closed 7 years ago

lucasdinonolte commented 7 years ago

When calling image_path with resizing option like so image_path article.data.cover, resize: '1200' the application fails:

wrong number of arguments (given 2, expected 1)
pmk1c commented 7 years ago

Sounds like the :images extension is not active. Maybe it's only active on build and your testing in development environment? Our extension can't workaround that (since it's not active).

Maybe we should add a dummy option. With this set, the extension can be activated, but doesn't do anything (for development).

juls commented 7 years ago

But wouldn't you also like to see how your resized images look like in development mode?

And it wouldn't solve Lucas' problem, so it should be another ticket (if needed).

pmk1c commented 7 years ago

@juls You're probably right.

Right now the README recommends to only activate it on build. We should change that, so that it recommends to only resize images in development mode, and resize / optimize on build. That would have prevented @lnolte's problem.

juls commented 7 years ago

Okay, could you update the README?

lucasdinonolte commented 7 years ago

We should change that, so that it recommends to only resize images in development mode, and resize / optimize on build.

Yes this works for me. Thanks. Also, why do we keep writing in english? 🇬🇧

juls commented 7 years ago

Something I've been asking myself the whole time 🤷‍♂️

ChristianPeters commented 7 years ago

Well, do we want to contribute it to the middleman community as an open source project? Then it makes sense to keep it international.

pmk1c commented 7 years ago

We want to underline our cosmopolitan spirit... and also what @ChristianPeters says.