search

zwicker-group / py-pde

Python package for solving partial differential equations using finite differences.
https://py-pde.readthedocs.io
MIT License
408 stars 52 forks source link

Add `num_cells` property to grids #291

Closed david-zwicker closed 2 years ago

david-zwicker commented 2 years ago

Replaced some np.prod and np.product calls with math.prod.

codecov[bot] commented 2 years ago

Codecov Report

Base: 87.84% // Head: 87.72% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (e1255bd) compared to base (d9f0553). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## ========================================== - Coverage 87.84% 87.72% -0.13% ========================================== Files 70 70 Lines 10345 10349 +4 ========================================== - Hits 9088 9079 -9 - Misses 1257 1270 +13 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `87.72% <100.00%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/zwicker-group/py-pde/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group) | Coverage Δ | | |---|---|---| | [pde/grids/\_mesh.py](https://codecov.io/gh/zwicker-group/py-pde/pull/291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group#diff-cGRlL2dyaWRzL19tZXNoLnB5) | `92.33% <100.00%> (-4.21%)` | :arrow_down: | | [pde/grids/base.py](https://codecov.io/gh/zwicker-group/py-pde/pull/291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group#diff-cGRlL2dyaWRzL2Jhc2UucHk=) | `89.82% <100.00%> (+0.04%)` | :arrow_up: | | [pde/tools/cuboid.py](https://codecov.io/gh/zwicker-group/py-pde/pull/291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group#diff-cGRlL3Rvb2xzL2N1Ym9pZC5weQ==) | `92.43% <100.00%> (ø)` | | | [pde/solvers/explicit\_mpi.py](https://codecov.io/gh/zwicker-group/py-pde/pull/291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group#diff-cGRlL3NvbHZlcnMvZXhwbGljaXRfbXBpLnB5) | `85.33% <0.00%> (-2.67%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zwicker-group)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging e1255bd8f38ab16a398aa57988ecaa8bbdde493a into d9f0553c8e31e6e8b44e570450c59fccbc6737a4 - view on LGTM.com

fixed alerts: