search

zwicker-group / py-pde

Python package for solving partial differential equations using finite differences.
https://py-pde.readthedocs.io
MIT License
410 stars 52 forks source link

Conflict of keyword method in kwargs of PDEBase.solver #475

Closed Cluckenstein closed 12 months ago

Cluckenstein commented 12 months ago

Team, I have noticed, that if one is to use the solve function with thesolver = ScipySolver, then the kwargs are forwarded to the ScipySolver, but the solver can use the keyword method to define which scipy solver is to be used. However in pde/pdes/base.py line 601 the kwarg key method is poped because of depreciation. Unfortunatly I cannot do a Pull request, thank you for all the work here !

david-zwicker commented 12 months ago

Thanks for the report – I added a quick fix to the master branch that should only warn if the solver argument is not set.