search

zwilias / elm-json

Install, upgrade and uninstall Elm dependencies
MIT License
183 stars 9 forks source link

0.19.1 support #14

Closed zwilias closed 5 years ago

zwilias commented 5 years ago

In order to support 0.19.1 when it is released, we need to take care of a few nits:

jfmengels commented 5 years ago

FYI, the elm-review CLI uses elm-json.

To work, it creates a new elm application directory (in elm-stuff/), adds dependencies (using elm-json), builds the project then runs it.

This stops working when I have the elm.json's version set to 0.19.1, and I get the following error message.

-- NO VALID PACKAGE VERSION ----------------------------------------------------

Because Elm 0.19.1 is unavailable and this project depends on Elm
0.19.1, no valid set of package versions could be found.

Let me know if I can help, and while I'm here, thanks a lot for the tool. It has been very useful and a pleasure to use :heart:

zwilias commented 5 years ago

Right. I'll release a version with 0.19.1 as a supported Elm version, and figure out the lookup paths/caching in a later iteration. It's purely an optimization anyway :)

zwilias commented 5 years ago

@jfmengels Initial compatibility should be good now, as of the 0.2.2 release! Let me know if that works for you :)

jfmengels commented 5 years ago

It works great, thank you!