search

zxbodya / yii2-gallery-manager

93 stars 61 forks source link

Set Base variables as protected for scalabiity #7

Open compleatguru opened 9 years ago

compleatguru commented 9 years ago

Hi!

I am proposing the changes so that anyone can extend your classes with ease and able to use them properly.

For your consideration, please.

zxbodya commented 9 years ago

Hi, thanks. Looks reasonable - partially merged your changes.

Except extending GalleryImage from yii\base\Model - why you need this?

compleatguru commented 9 years ago

On extending GalleryImage from yii\base\Model, this will allow me to adopt multilingual behavoir for GalleryImage name and description.

In other words, each image can have its own name and description in different languages.

See https://github.com/OmgDef/yii2-multilingual-behavior.

What do you think?