search

zxc23 / dcss-scoreboard

A bundle of scripts to create a scoreboard website for the roguelike game Dungeon Crawl Stone Soup..
9 stars 5 forks source link

Fixing Scoring to support new version #6

Closed bbrandes closed 7 years ago

bbrandes commented 7 years ago

Urls that work:

Doesn't work yet (but anticipate it will eventually and doesn't seem to hurt):

bbrandes commented 7 years ago

bitmoji

alexjurkiewicz commented 7 years ago

The file is a copy of this one: https://github.com/crawl/sequell/blob/HEAD/config/sources.yml, so the PR should just follow that repo

bbrandes commented 7 years ago

As you requested, I've re-copied and pasted from the file, but, I don't think that's the best solution.

The bad

Biggest issue is that sequell doesn't know about CAO yet (and thus removed it) even though it is up.

the neutral

I guess it removed CUE from attempting to download its files (even though that didn't seem to hurt). CJR is still down, but I didn't add that server in manually either.

the good

Looks like it also added the experimental branches, I definitely didn't even think about those

It'd be nice if we had the ability to link this external file as a dependency not through code, but that'd require a bit of a build process. I guess this is once or twice a year kinda job anyway.

bbrandes commented 7 years ago

I'm still of the opinion we should definitely add back in CAO, ad also suggest to proactively add in the 0.19 entries for CUE and CJR despite them not being available yet... but your repos, your rulez

alexjurkiewicz commented 7 years ago

You can do that with a PR to sequell, then we can update the file again. It's an annoying sequence but maintaining a source list in parallel is extra work.

On Wed., 2 Nov. 2016, 2:55 am bbrandes, notifications@github.com wrote:

I'm still of the opinion we should definitely add back in CAO, ad also suggest to proactively add in the 0.19 entries for CUE and CJR despite them not being available yet...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zxc23/dcss-scoreboard/pull/6#issuecomment-257605148, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXKdbgO8pd2CRgN5LhzIZU_DQGhmz7Pks5q52DvgaJpZM4KlyHs .

bbrandes commented 7 years ago

Okay... we're up to date with what's currently in Sequell... Do you wanna merge this ticket as a copy of its current state or wait until a PR goes through on CUE to add that server?

alexjurkiewicz commented 7 years ago

Might as well merge now. Thanks for the update!