search

zxcalc / quantomatic

Quantomatic is a tool for doing automated graph rewriting.
http://quantomatic.github.io
151 stars 22 forks source link

Cannot delete proof steps #212

Closed akissinger closed 5 years ago

akissinger commented 6 years ago

During a derivation, clicking "Delete proof step" sometimes does nothing. This seems to happen when there are multiple branches.

SaraWolffs commented 6 years ago

Unless there's a separate bug giving similar issues, the cause is https://github.com/scala/scala-swing/issues/73 , introduced between 2.0.1 and 2.0.2. Short version: Dialog.Result, the enum class, throws. Not "if you do this", just "if your code uses Dialog.Result in any way, that line throws". That was severe enough to cause them to declare 2.0.2 critically broken and push out 2.0.3 the day after the fix was merged.

Local build confirms bumping scala-swing to 2.0.3 in build.sbt fixes it. I'll fork and prepare a PR.

SaraWolffs commented 6 years ago

Done and tested on a clean clone. If someone could merge #219 , that should fix it.

jvdwetering commented 5 years ago

Closed by 8d24d41