improvement(typing): Use PySide6 generated stubs

zxcalc / zxlive

A graphical tool for the ZX calculus

Apache License 2.0

45 stars 15 forks source link

improvement(typing): Use PySide6 generated stubs #282

Closed boldar99 closed 4 days ago

boldar99 commented 5 days ago

Since PySide6>=6.7 includes stub files, we can drop the PySide6-stubs dependency.

jvdwetering commented 5 days ago

This page says that pyside6 already ships with the stubs: https://doc.qt.io/qtforpython-6/tools/pyside-genpyi.html Is it necessary for us to regenerate them?

boldar99 commented 5 days ago

Yeah, you're right, I missed that. I'll fix these soon. Should I keep the changes to README.md (excluding the part about pyside6-genpyi) or revert the file complately?

RazinShaikh commented 5 days ago

Why not keep the info about running tests in the readme? It's good to have and is only a few sentences.

boldar99 commented 5 days ago

Okay, I put that back