Closed ghost closed 1 year ago
I see where you are coming from. This feature would result in an complete rewrite 🤔
Just for information, you could throw every dictionary into it. This would only improve the scoring in the end. You don't need to separate them .
Hi, thanks for responding :)
If easy, performant and relevant (I think), make it possible to pass any different options on the evaluation step directly ..
like let result = zxcvbn(password, options)
Unfortunately this is not possible because setting the graphs takes quite some time
ok I understand, I thought there is something underneath and this is why options are set before. Anyway, for me it does work with Mutex with multiple imports on server. Thanks a lot
Hi, thanks a lot for the amazing work ! I'm planning to add zxcvbn to my Node server.
Multilanguage for validation is perfect feature :) Setting option while it is handled implicitly I found not the best I don't know what is the constraints for you :)
because I want to use English, French and maybe other languages, (it is fine for me I guess to load all dictionaries because on server side), so because Node is monoprocess, I guess I need attach options just before running the validation, or safer have many objects of
import { zxcvbn, zxcvbnOptions } from '@zxcvbn-ts/core'
for different languages. This is not possible in Node something likeimport { zxcvbn as zxcvbnEn, zxcvbnFr, zxcvbnOptionsEn, zxcvbnOptionsFr } from '@zxcvbn-ts/core'
The problem is if I do
import { zxcvbn, zxcvbnOptions } from '@zxcvbn-ts/core'
Then depending on current language for one session, one can step on another toe, it would be better to be able to instantiate likelet validatorEn = new zxcvbn()
I'm doing a whole async mutex to achieve this (having one
zxcvbn
instance)I hope you get my idea. Most important is to have a constructor to create new instances.