search

zxcvbn-ts / zxcvbn

Low-Budget Password Strength Estimation
https://www.usenix.org/conference/usenixsecurity16/technical-sessions/presentation/wheeler
MIT License
910 stars 72 forks source link

Typing issue #227

Closed MichaelAlt closed 1 year ago

MichaelAlt commented 1 year ago

https://github.com/zxcvbn-ts/zxcvbn/blob/ce3aed62ab3e95ebf89cec0ece737eb8579149a9/packages/libraries/main/src/matcher/spatial/matching.ts#L44

Leads to typing error in v3.0.3 image

MrWook commented 1 year ago

Hey thank you for the issue but shouldn't you exclude the node_modules folder with the tsconfig? Naturally i will fix it but it's weird that i won't get this obvious type issue 🤔

MichaelAlt commented 1 year ago

Yey you are correct it was an "accidential find" :) Our karma tests failed even though node_modules ist excluded in our tsconfig. The error is only shown because we have noImplicityAny: false set in the tsconfig.