search

zxcvbn-ts / zxcvbn

Low-Budget Password Strength Estimation
https://www.usenix.org/conference/usenixsecurity16/technical-sessions/presentation/wheeler
MIT License
910 stars 72 forks source link

No warning for Indonesian names #264

Closed zeezooz closed 3 months ago

zeezooz commented 3 months ago

The dictionary name contains just "names":

https://github.com/zxcvbn-ts/zxcvbn/blob/9597238aefe6dff2b53e1680240e769fa2abcf76/packages/languages/id/src/index.ts#L9

But it must contain "lastnames" or "firstnames" to get a warning:

https://github.com/zxcvbn-ts/zxcvbn/blob/9597238aefe6dff2b53e1680240e769fa2abcf76/packages/libraries/main/src/matcher/dictionary/feedback.ts#L54-L56