zxcvbn-ts / zxcvbn

Low-Budget Password Strength Estimation
https://www.usenix.org/conference/usenixsecurity16/technical-sessions/presentation/wheeler
MIT License
907 stars 72 forks source link

Dummy translation keys file part of the build. #81

Closed JonL1 closed 2 years ago

JonL1 commented 2 years ago

Is there any reason why this file is part of the build?

https://github.com/zxcvbn-ts/zxcvbn/blob/master/packages/libraries/main/src/data/translationKeys.ts

I assume it's just a dummy file that should serve as a template. Depending on how you load the scripts it can happen that these dummy keys are loaded instead of the right ones messing up the UI.

image

JonL1 commented 2 years ago

No need for changes. I found i sneaky bug in my code.

MrWook commented 2 years ago

Actually just for future reference, those keys are for people that have their own translation system. This was requested a lot in the original repository.

JonL1 commented 2 years ago

Oh I see. So something like passing those keys to i18next. Thanks for the explanation.