search

zxing-js / browser

ZXing for JS's browser layer with decoding implementations for browser.
MIT License
213 stars 43 forks source link

fix: Add missing await #116

Closed ddoice closed 1 year ago

ddoice commented 1 year ago

controls.stop

This line is missing an await when calling switchTorch, so if it fails theres no way to capture the error in a try catch.

https://github.com/zxing-js/browser/blob/9e0ef5e4a661a5989a9b4a97117a20b1fcd4527d/src/readers/BrowserCodeReader.ts#L755

image

ddoice commented 1 year ago

Can you help me please @werthdavid ?

werthdavid commented 1 year ago

Thanks, much appreciated!

werthdavid commented 1 year ago

I need so fix the delivery workflow to create a new release though. Maybe later today