search

zxing-js / browser

ZXing for JS's browser layer with decoding implementations for browser.
MIT License
213 stars 43 forks source link

Does @zxing/browser want to peer-depend on @zxing/library? #130

Closed olleolleolle closed 3 months ago

olleolleolle commented 6 months ago

Hello! 👋

Thanks for maintaining the health of this package! 🧑‍⚕️

I'm curious if it would be possible to say "@zxing/browser has a peer dependency on @zxing/library"? https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependencies

And, if set, it would offer "package tips" to people who didn't know that the two are connected.

TheWirv commented 3 months ago

Have you checked the package.json? This is already the case (and has been for a long time).

olleolleolle commented 3 months ago

You are absolutely right, https://github.com/zxing-js/browser/commit/5228f6d674d15cc4035bb26c6af111fda180799c added what I asked for, long ago. Closing!