zxing-js / browser

ZXing for JS's browser layer with decoding implementations for browser.
MIT License
216 stars 43 forks source link

Tracking on created streams #73

Closed lazoapostolovski closed 2 years ago

lazoapostolovski commented 2 years ago

Fix for https://github.com/zxing-js/ngx-scanner/issues/425

rvalitov commented 2 years ago

@werthdavid Can you please approve and merge this PR?

rvalitov commented 2 years ago

@werthdavid thank you so much. Will you publish a new release yourself or should we make a PR to package.json?

werthdavid commented 2 years ago

PR would be much appreciated, thank you!!

rvalitov commented 2 years ago

@werthdavid Sorry, the PR will not work. Because package.json is in .gitignore. It seems you need to run npm pack yourself and make a release appropriately. Or do you think we should allow contributors to edit the package.json and commit it?

P.S. I reviewed the following PRs that can also be merged:

Also added a couple PRs of mine:

Please, have a look when you have time for that. Thank you!

werthdavid commented 2 years ago

Can you check if v0.0.10 works as expected? Thanks for all the work!

rvalitov commented 2 years ago

Thank you so much! I started to test. I will inform about the results.

rvalitov commented 2 years ago

@werthdavid I made the tests. I could successfully run the zxing-js/ngx-scanner with browser v.0.0.10 and Angular 12.2.3.: image However, I had to fix a few things, see the PR https://github.com/zxing-js/ngx-scanner/pull/447

Also, I found out, that latest version of https://github.com/zxing-js/library is v0.19.0, however it has not been published at npm. Is there any reason for that? So, I made the tests with v0.18.0. If you publish v.0.19.0, then I can test it, too.

I also linked the locally built ngx-scanner to my own project, instead of the npm package that I used previously. It also works without any issues.

I believe you may merge the PR above, and then publish a new ngx-scanner version to npm. Thank you!

werthdavid commented 2 years ago
rvalitov commented 2 years ago

Thank you so much! The ngx-scanner version 3.3.0 from npm works like a charm!

werthdavid commented 2 years ago

Good stuff!