Closed lazoapostolovski closed 2 years ago
@werthdavid Can you please approve and merge this PR?
@werthdavid thank you so much. Will you publish a new release yourself or should we make a PR to package.json
?
PR would be much appreciated, thank you!!
@werthdavid Sorry, the PR will not work. Because package.json
is in .gitignore
. It seems you need to run npm pack
yourself and make a release appropriately. Or do you think we should allow contributors to edit the package.json
and commit it?
P.S. I reviewed the following PRs that can also be merged:
Also added a couple PRs of mine:
Please, have a look when you have time for that. Thank you!
Can you check if v0.0.10 works as expected? Thanks for all the work!
Thank you so much! I started to test. I will inform about the results.
@werthdavid I made the tests. I could successfully run the zxing-js/ngx-scanner
with browser v.0.0.10 and Angular 12.2.3.:
However, I had to fix a few things, see the PR https://github.com/zxing-js/ngx-scanner/pull/447
Also, I found out, that latest version of https://github.com/zxing-js/library is v0.19.0, however it has not been published at npm. Is there any reason for that? So, I made the tests with v0.18.0. If you publish v.0.19.0, then I can test it, too.
I also linked the locally built ngx-scanner
to my own project, instead of the npm package that I used previously. It also works without any issues.
I believe you may merge the PR above, and then publish a new ngx-scanner
version to npm. Thank you!
Thank you so much! The ngx-scanner version 3.3.0 from npm works like a charm!
Good stuff!
Fix for https://github.com/zxing-js/ngx-scanner/issues/425