search

zxing-js / library

Multi-format 1D/2D barcode image processing library, usable in JavaScript ecosystem.
https://zxing-js.github.io/library/
Apache License 2.0
2.51k stars 547 forks source link

fix: broken demo links #483

Closed gnekich closed 2 years ago

gnekich commented 3 years ago

This PR is fixing the issue with invalid links on demo pages.

Old link https://unpkg.com/@zxing/library@latest returns HTTP 404. Updated all the links to the: https://unpkg.com/@zxing/library@latest/umd/index.min.js

Strangely enough 1 example file multi-camera already had updated link but all other demo pages did not. Tested it locally using npx serve I was able to run all the examples.

rvalitov commented 3 years ago

Looks like a duplicate of #475 . But this PR uses @latest version in all files.

gnekich commented 3 years ago

Can we please get this or #475 merged ? I don't see why this is still open, it is a simple fix, and the demo is currently broken.

WIStudent commented 2 years ago

This should have been fixed by https://github.com/zxing-js/library/pull/452 in version 0.19 but unfortunately some broken tests prevented v0.19 from being pushed to npm.

werthdavid commented 2 years ago

So as 0.19 is published correctly now, is this obsolete?

werthdavid commented 2 years ago

No answer