search

zxing-js / library

Multi-format 1D/2D barcode image processing library, usable in JavaScript ecosystem.
https://zxing-js.github.io/library/
Apache License 2.0
2.51k stars 547 forks source link

Fix check for the type HTMLVideoElement #530

Closed ti777777 closed 1 year ago

ti777777 commented 2 years ago

fix #493 #497 #516 #520 #525

ti777777 commented 2 years ago

Hi, Does anybody can help to review this PR

mageshk98 commented 2 years ago

@mmalomo @ti777777 Any idea when this will be merged into the master?

ti777777 commented 2 years ago

@mmalomo @ti777777 Any idea when this will be merged into the master?

Sorry,I am not the maintainer. I have no idea.😅

mageshk98 commented 1 year ago

A temporary hack worked for me.

const img = document.getElementById('img'); img.videoWidth = 0; codeReader.decodeFromImage(img).then((result) => { //Logic goes here }

werthdavid commented 1 year ago

Can u update the merge conflicts? I will then merge this!

werthdavid commented 1 year ago

I fixed it directly on master